nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattyb149 <...@git.apache.org>
Subject [GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...
Date Mon, 06 Feb 2017 16:39:25 GMT
Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/1450
  
    Koji has a good point about managing the actual DataSource instance internally, if your
use case can be accomplished without needing access to this object, then I would tend to agree
that we shouldn't expose it.
    
    Having said that, I have a use case where I need to get at some of the properties of the
controller service. Processors get a ProcessContext passed into some of their methods (like
onTrigger) and can use that to get PropertyValues. The ControllerService interface extends
ConfigurableComponent (not ConfiguredComponent) so I can currently only get access to the
PropertyDescriptors, not the PropertyValues themselves.
    
    A compromise might be to expose getter methods from DBCPService to retrieve things like
JDBC URL, username, password, etc. However if this could turn into a common pattern for controller
services, we should investigate a framework- or API-level solution, such as a getProperty()
method added to ControllerService or something.  What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message