Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
From: pvillard31 <git@git.apache.org>
To: issues@nifi.apache.org
Reply-To: issues@nifi.apache.org
References: <git-pr-1034-nifi@git.apache.org>
In-Reply-To: <git-pr-1034-nifi@git.apache.org>
Subject: [GitHub] nifi pull request #1034: [NIFI-2810] Allow Content Type to be set in PutS3Ob...
Content-Type: text/plain
Message-Id: <20160923140556.08CF2E01BA@git1-us-west.apache.org>
Date: Fri, 23 Sep 2016 14:05:55 +0000 (UTC)
archived-at: Fri, 23 Sep 2016 14:05:57 -0000

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1034#discussion_r80250162
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java ---
    @@ -132,6 +132,19 @@
             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
             .build();
     
    +    public static final PropertyDescriptor CONTENT_TYPE = new PropertyDescriptor.Builder()
    +        .name("Content Type")
    --- End diff --
    
    Could you use the combination of ``.name()`` and ``.displayName()``? name ensures backward compatibility when displayName allows to be more flexible on what is displayed to users. We are trying to ensure every new processor properties is using both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---