nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-2629) Hide add property "+" in Processors, Controller Services and Reporting Tasks that don't allow dynamic properties
Date Thu, 01 Sep 2016 20:57:20 GMT

    [ https://issues.apache.org/jira/browse/NIFI-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456591#comment-15456591
] 

ASF GitHub Bot commented on NIFI-2629:
--------------------------------------

Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/969
  
    I would recommend relying on the annotation only.  This allows a processor
    implementer to opt-in and is explicit and clear.  It does though mean a
    behavioral change that debatably is a 2.0 thing.  I think I'd argue it
    doesn't but I could see others having a different view.
    
    Thanks
    Joe
    
    On Sep 2, 2016 6:30 AM, "Kirk" <notifications@github.com> wrote:
    
    > If the DynamicProperty annotation is absent, I can check if the
    > getSupportedDynamicPropertyDescriptor method is defined in
    > AbstractConfigurableComponent. I'll hide the '+' if the annotation is
    > present or if the method is overridden. Thoughts?
    >
    > On Tuesday, August 30, 2016, Peter <notifications@github.com
    > <javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:
    >
    > > I would love to just show/hide it, but I can see where people are coming
    > > from.
    > > What if for v1.1 an outright show/hide was replaced with an alternative
    > > color, maybe make the button look like it's disabled while leaving it
    > > enabled by applying a CSS class. This would at least give a visual
    > > indication to users without breaking anything for custom processors.
    > >
    > > Try to let users know what's going to happen, get other processors
    > > updated, then in v1.x you can start actually showing/hiding?
    > >
    > > —
    > > You are receiving this because you were mentioned.
    > > Reply to this email directly, view it on GitHub
    > > <https://github.com/apache/nifi/pull/969#issuecomment-243648647>, or
    > mute
    > > the thread
    > > <https://github.com/notifications/unsubscribe-auth/
    > ABcVqBOpHslqrKTjYHczwCaGPbd0x0RZks5qlPVGgaJpZM4JwNlu>
    > > .
    > >
    >
    >
    > --
    > Kirk Tarou
    > The 9:20 Special - Lindy Hop & Swing Dance Venue
    > 2460 Sutter Street, San Francisco, CA, 94115
    > www.920special.com
    > Find us here: Facebook <http://www.facebook.com/group.php?gid=8134453869>
    > Twitter <http://twitter.com/920special> Yelp!
    > <http://www.yelp.com/biz/9-20-special-san-francisco> YouTube
    > <http://www.youtube.com/920special>
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/nifi/pull/969#issuecomment-244180302>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AC6nOfPkPGaxEFT7ByS0IYiZnjMXyDsMks5qlyKKgaJpZM4JwNlu>
    > .
    >



> Hide add property "+" in Processors, Controller Services and Reporting Tasks that don't
allow dynamic properties
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-2629
>                 URL: https://issues.apache.org/jira/browse/NIFI-2629
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework, Core UI
>    Affects Versions: 0.7.0
>            Reporter: Kirk Tarou
>            Priority: Minor
>
> A few Processors, Controller Services and Reporting Tasks expect or allow extra properties
to be added on the 'Properties' tab in the Detail view. The rest will show a "not a supported
property" error.
> To avoid confusion, the new property "+" icon should be hidden if dynamic properties
are not allowed.
> The existence of a "DynamicProperty" annotation could be used as an indicator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message