nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-2266) GetHTTP and PutHTTP use hard-coded TLS protocol version
Date Tue, 13 Sep 2016 21:22:20 GMT

    [ https://issues.apache.org/jira/browse/NIFI-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488473#comment-15488473
] 

ASF GitHub Bot commented on NIFI-2266:
--------------------------------------

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/999
  
    @pvillard31 and @mosermw , thanks for noting that. When I re-ran locally, I encountered
the same issue. I have resolved it, but not to my complete satisfaction. The test now accepts
that _n_ flowfiles were routed to `REL_SUCCESS` instead of _1_ explicitly. As the tests are
simply concerned with the TLS protocol version used for the communication, this seems a sufficient
fix. However, I am confused, because it appears from the logs and debugging that the test
runner "finds" a mock flowfile in the queue even if I assert immediately before enqueuing
any message that the queue is empty. 
    
    I'll continue investigating, but I did want to push this fix so at least the tests pass
for anyone reviewing it. 


> GetHTTP and PutHTTP use hard-coded TLS protocol version
> -------------------------------------------------------
>
>                 Key: NIFI-2266
>                 URL: https://issues.apache.org/jira/browse/NIFI-2266
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 0.7.0, 0.6.1
>            Reporter: Andy LoPresto
>            Assignee: Andy LoPresto
>              Labels: https, security, tls
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> As pointed out on the mailing list [1], the {{GetHTTP}} (and likely {{PutHTTP}}) processors
use a hard-coded TLS protocol version. {{PostHTTP}} also did this and was fixed by [NIFI-1688].

> The same fix should apply here and unit tests already exist which can be applied to the
other processors as well. 
> For future notice, {{InvokeHTTP}} is a better processor for generic HTTP operations and
has supported reading the TLS protocol version from the {{SSLContextService}} for some time.

> [1] https://lists.apache.org/thread.html/a48e2ebbc2231d685491ae6b856c760620efca5bff2c7249f915b24d@%3Cdev.nifi.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message