nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pvillard31 <...@git.apache.org>
Subject [GitHub] nifi pull request #1037: NIFI-1893 Add processor for validating JSON
Date Wed, 21 Sep 2016 13:35:11 GMT
Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1037#discussion_r79830777
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
    @@ -249,6 +249,11 @@ language governing permissions and limitations under the License.
-->
                 <artifactId>super-csv</artifactId>
                 <version>2.4.0</version>
             </dependency>
    +        <dependency>
    +            <groupId>org.everit.json</groupId>
    +            <artifactId>org.everit.json.schema</artifactId>
    +            <version>1.4.0</version>
    +        </dependency>
    --- End diff --
    
    In the pom file, you also have to add the json files you added for testing purpose in
order to exclude those files during the rat check (licensing aspects). You can check that
everything is fine by running a mvn clean install with the profile contrib-check:
    ````
    mvn clean install -Pcontrib-check
    ````
    Side note: from where are coming the json files your are using for tests? (just to be
sure there is no issue)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message