nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pvillard31 <...@git.apache.org>
Subject [GitHub] nifi pull request #986: Nifi 2381
Date Fri, 16 Sep 2016 17:34:54 GMT
Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/986#discussion_r79215167
  
    --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
    @@ -114,6 +114,17 @@
             .sensitive(false)
             .build();
     
    +    public static final PropertyDescriptor VALIDATION_QUERY = new PropertyDescriptor.Builder()
    +            .name("Validation query")
    +            .description("Validation query used to validate connections before returning
them."
    +                + "When connection is invalid, it get's dropped and new valid connection
will be returned."
    +                + "Note!! Using validation might have some performance penalty.")
    +            .defaultValue(null)
    --- End diff --
    
    I don't think default value to null is necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message