From dev-return-20835-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Tue Mar 24 17:37:45 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5D2EE18065C for ; Tue, 24 Mar 2020 18:37:45 +0100 (CET) Received: (qmail 19569 invoked by uid 500); 24 Mar 2020 17:37:44 -0000 Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list dev@nifi.apache.org Received: (qmail 19556 invoked by uid 99); 24 Mar 2020 17:37:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Mar 2020 17:37:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B56AE180D5A for ; Tue, 24 Mar 2020 17:37:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5z-IVQ3PDeTl for ; Tue, 24 Mar 2020 17:37:41 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::234; helo=mail-lj1-x234.google.com; envelope-from=czobrisky@gmail.com; receiver= Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 4A0997DD9C for ; Tue, 24 Mar 2020 17:37:41 +0000 (UTC) Received: by mail-lj1-x234.google.com with SMTP id w1so19503528ljh.5 for ; Tue, 24 Mar 2020 10:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=smTmElH+6lvVP+B4XWAquo+sAdgaFArzZPhUqk+MlX4=; b=cRJS70AnRo+/sX5XAdPskyBD85H/eg3+VznqNxYlITb3m2OJ7CHaH6aHeiYGe/Wt2q yrh2F1dZt0PGOVrNQK+RJ5L25inQAx8fXJ7O7A0exWMXg4gq+zFJ50kwk5Xh4aDf2HSF pr+SmR3LjaRF0Fl4s+/ZOJ8mSc+myzfx1X0k+qp0J1LivvjF4EPixhfOeL7vzB+bkEx7 GLLJo1DkI4Kd50uaZr6uMmgShH6rB+Tx7xMtxqab2cDGH8Q/JVEv2kq6p4gv3JJvCoqD v4HYHXnh51D1d5j0O9vsqlF6lY/Wajpx7E3ACP5XZqG0EIqrSvkFE+YBWzJ4eoZ362SF REbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=smTmElH+6lvVP+B4XWAquo+sAdgaFArzZPhUqk+MlX4=; b=LGBTwfG327h6ty1r1Uwf5ke2oCZd0lD8Tk5glx9Y21vtsM/JVik/DOpgh9Yh/xw/hA pL1bsfMDIMKbJ1qd99J3PbMAHPaBmczAGyLxb/dNO9Qpz1nFQFWGRvH82jKBLRjdZJ+K 0HxkTyyRpBkC0bo7LAZpal5riGe4Fq0nqUQ3wUpuu+Z5Gc0QpgpC8kCkigdj8CyXd8vT AXdLsLzaK04aLff2XRxDYloD9ZceDBDxSePB1iUPlWTtou/8GskwfH4jJBDFQM5DGaQq +RLz/lCTs2v452GlKrs3W69sqBpWWmMALxjVeLJBD00WzaW+iz+gNP9PgM2g5ImDtVyb +x0g== X-Gm-Message-State: ANhLgQ0ObD0m93I+aaxfjnhkb4Mn1aYfrUcgeWIYSvrciX5D4tJC4iQv O8feyQWwDncyDP45VPzm5ghZPiG3hfCzOviBq8Qu0DvR X-Google-Smtp-Source: ADFU+vuWc4VYDH1BqOD9eVn8C/pp5IDy4+1Xdk7UpO4aZCZZyVABUb5MhnYEkFgWulyWsBJluYqfECVo9vjiJw7YpH4= X-Received: by 2002:a2e:9c8:: with SMTP id 191mr17513376ljj.259.1585071454183; Tue, 24 Mar 2020 10:37:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Chad Zobrisky Date: Tue, 24 Mar 2020 13:37:22 -0400 Message-ID: Subject: Re: Upgrade to Avro 1.9.X To: dev@nifi.apache.org Content-Type: multipart/alternative; boundary="000000000000f8673b05a19d3436" --000000000000f8673b05a19d3436 Content-Type: text/plain; charset="UTF-8" As I don't have much experience with Nifi's actual avro code and parsing, I can't comment much on the points you made Matt, specifically the bug you pointed out, 2742. But when I last looked at upgrading all avro dependencies to 1.9.x it was a larger amount of work do to how the JSON nodes are referenced. I cannot remember what the exact issue was, but it wasn't a quick drop and replace with maybe a handful of edits. Maybe I was looking at the wrong thing though... On Tue, Mar 24, 2020 at 1:26 PM Matt Burgess wrote: > Looking at the Jiras that were released between 1.8.1 (our current > version) and 1.9.2 (the current GA version of Avro) [1], it appears > that if we were to upgrade Avro, we definitely should go to the latest > (there are a number of regressions in 1.8.2 and 1.9.0 for example). > However I'm a little leery of [2], it shouldn't affect anything we do > inside NiFi, but I wonder if it's a dealbreaker for upgrade. What are > your thoughts? For reference, [3] is the list of open issues against > 1.9.2 specifically, of course there may be some that are to be fixed > in 1.9.3 but there aren't any yet with 1.9.3 set as a fix version, and > I'm not a member of the Avro community so I don't know when/if 1.9.3 > will be released (or if [2] will be in it). > > I also haven't tried just upgrading on my local branch and running all > tests, will do that shortly. > > Thanks, > Matt > > [1] > https://issues.apache.org/jira/browse/AVRO-1861?jql=project%20%3D%20AVRO%20AND%20fixVersion%20in%20(1.8.2%2C%201.9.0%2C%201.9.1%2C%201.9.2)%20AND%20component%20%3D%20java%20ORDER%20BY%20created%20DESC > [2] https://issues.apache.org/jira/browse/AVRO-2742 > [3] > https://issues.apache.org/jira/browse/AVRO-2742?jql=project%20%3D%20AVRO%20AND%20affectedVersion%20%3D%201.9.2%20AND%20component%20%3D%20java%20ORDER%20BY%20created%20DESC > > On Tue, Mar 24, 2020 at 10:13 AM Chad Zobrisky > wrote: > > > > Mike, > > > > I've been looking at this upgrade for a while since a bug in 1.8.x I ran > > into with a JSON NULL error[1]. Wasn't sure how to proceed since quite a > > few nars have dependencies on the avro and wasn't sure if they should be > > upgrade together or not. Would love to work with you on this if possible. > > > > 1. https://issues.apache.org/jira/browse/AVRO-1954 > > > > Chad > > > > On Tue, Mar 24, 2020 at 9:59 AM Mike Thomsen > wrote: > > > > > Are there any blockers here that would prevent us from upgrading and > > > including the new UUID logical type in the record api? > > > > > > https://avro.apache.org/docs/1.9.2/spec.html#UUID > > > > --000000000000f8673b05a19d3436--