nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arpad Boda <ab...@cloudera.com.INVALID>
Subject Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.7.0 (RC1)
Date Sat, 11 Jan 2020 17:30:39 GMT
+1 - verified build, checksums and execution on Debian.

Thanks all for the documentation improvements, will adjust helper and
readme accordingly!

On Sat, Jan 11, 2020 at 3:57 AM Andy LoPresto <alopresto@apache.org> wrote:

> +1 (binding)
>
> I encountered a number of obstacles during this validation, some of which
> are definitely because I haven’t worked on the C++ effort (or even built
> it) in at least 6 months. These are not complaints, just wrinkles I
> captured so we can improve this process for next time. Noted here for
> posterity:
>
> * The SHA-512 digest I calculated locally matched the email, but the
> .sha512 files are not published in the hosted server for any artifacts.
> * The GPG verification command in the helper email should include -v to
> show the underlying digest algorithm used
> * The wget commands have newlines inserted, which means they cannot be
> copied/pasted into the terminal without manual modification
> * The README section on bootstrapping helped immensely, but is not
> perfectly aligned with the current process
> * The wording of “disable tests…..disabled” is unclear (in this case it
> means that the tests will be run)
> * The bootstrap instructions are missing the directive to change into the
> build/ directory before running make (directory in example prompt is wrong)
> * The bootstrap instructions are missing the directive to untar the binary
> artifact and change into that directory before running ./bin/minifi.sh start
> * A sample flow (config.yml) with a GenerateFlowFile and LogAtttribute
> flow would be helpful to allow people to verify the successful install of
> MiNiFi without going through the full flow design in NiFi, export template,
> convert template process
>
> All in all, a lot of great work done on this release. Thanks Arpad.
>
>
> Andy LoPresto
> alopresto@apache.org
> alopresto.apache@gmail.com
> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4  BACE 3C6E F65B 2F7D EF69
>
> > On Jan 10, 2020, at 12:55 PM, Matt Gilman <matt.c.gilman@gmail.com>
> wrote:
> >
> > +1 (binding)
> >
> > Ran through release helper. Verified signature, checksums, build, tests,
> > etc. Looks good.
> >
> > Thanks for RMing Arpad!
> >
> > On Fri, Jan 10, 2020 at 3:39 PM Kevin Doran <kdoran.apache@gmail.com>
> wrote:
> >
> >> +1 (binding)
> >>
> >> Ran through the steps in the release helper guide. Noticed a few
> >> release helper instructions that can be improved for next time (no
> >> mention of bootstrap.sh),
> >> but was able to figure it out by using the README file included in the
> >> source release.
> >>
> >> Hashes & sig all looked good. Was able to build, including the docker
> >> image. Tests
> >> all passed. Tested integration with a NiFi cluster with the 0.7.0
> >> minifi sending flow files over s2s and everything worked as expected.
> >>
> >> Overall, seems to be a very solid, polished release. Nice work all!
> >>
> >> On Fri, Jan 10, 2020 at 3:35 PM Joe Witt <joe.witt@gmail.com> wrote:
> >>>
> >>> +1 (binding)
> >>>
> >>> Comments
> >>> - Notice file copyright year needs to be 2020
> >>> - I did not enable python support but I get the minifi-python dir
> anyway
> >>> and log entry on startup such as
> >>>   Caught Exception ModuleNotFoundError: No module named 'google'
> >>>
> >>> Great progress with this release!  Nice work.  Building and running
> tests
> >>> was easier than I ever remember.
> >>>
> >>> Thanks
> >>>
> >>> On Fri, Jan 10, 2020 at 8:27 AM Dániel Bakai <bakaid.apache@gmail.com>
> >>> wrote:
> >>>
> >>>> +1, non-binding
> >>>>
> >>>> Verifications performed:
> >>>>
> >>>> SHA256 checksums downloaded: OK
> >>>> SHA512 checksum of nifi-minifi-cpp-0.7.0-source.tar.gz sent in mail:
> OK
> >>>> GPG signatures downloaded: OK
> >>>> Git tag in email matches sources in
> >> nifi-minifi-cpp-0.7.0-source.tar.gz: OK
> >>>>
> >>>> bootstrap.sh with default options && make && make package
&& sudo make
> >> test
> >>>> ARGS="-j4 --output-on-failure" && run package with a GenerateFlowFile
> >> ->
> >>>> LogAttribute flow:
> >>>> macOS 10.14.6: TailFileTests sometimes fail, otherwise OK
> >>>> ubuntu:bionic docker container: had to install 'tzdata' package for
> >>>> ExpressionLanguageTest to work, CTailFileChunkTests and
> >>>> CTailFileDelimitedTests consistently fail when ran in parallel,
> running
> >>>> them sequentially works, otherwise OK
> >>>> centos:7 docker container: had to install 'zlib-devel' and 'which',
> >>>> otherwise OK
> >>>> debian:stretch docker container: OK
> >>>> fedora:29 docker container: had to install 'zlib-devel' and 'which',
> >>>> otherwise OK
> >>>> ubuntu:xenial docker container: had to install 'tzdata' package for
> >>>> ExpressionLanguageTest to work, otherwise OK
> >>>>
> >>>> Run appropriate convenience binary with a GenerateFlowFile ->
> >> LogAttribute
> >>>> flow:
> >>>> macOS 10.14.6: OK
> >>>> ubuntu:bionic docker container: OK
> >>>> centos:7 docker container: OK
> >>>> debian:stretch docker container: OK
> >>>> fedora:29 docker container: OK
> >>>> ubuntu:xenial docker container: OK
> >>>> General note: there is a dynamic libpython dependency in most *nix
> >>>> convenience binaries, requiring manual installation from the native
> >> repos,
> >>>> in the case of CentOS 7 from EPEL.
> >>>>
> >>>> win_build_vs.bat build /64 /K /P && ctest -C Release &&
run package
> >> with a
> >>>> GenerateFlowFile -> LogAttribute flow:
> >>>> Windows 10: TailFileTests failed, but this is, as far as I know, a
> >> known
> >>>> issue, otherwise OK
> >>>>
> >>>> Install convenience msi on a completely clean Windows VM and run with
> a
> >>>> GenerateFlowFile -> LogAttribute flow both as a service and from
> >> cmd.exe:
> >>>> Windows 7: OK
> >>>> Windows 10: OK
> >>>>
> >>>>
> >>>> I think this release brings great improvements over 0.6.0.
> >>>>
> >>>> On Fri, 10 Jan 2020 at 02:32, Aldrin Piri <aldrinpiri@gmail.com>
> >> wrote:
> >>>>
> >>>>> +1, binding
> >>>>>
> >>>>> Comments:
> >>>>> * signature and hashes looked good
> >>>>> * license and notification looked correct and comprehensive
> >>>>> * performed build and test successfully on Ubuntu 19.04, CentOS
7,
> >> and
> >>>>> MacOS 10.14
> >>>>> * ran a variety of flows and achieved expected results
> >>>>> * we should update the helper to have folks make use of the
> >> bootstrap or
> >>>>> enumerate the needed dependencies.  the prescribed approach worked
> >> for me
> >>>>> as all systems had the requisite tools and dependencies, but others
> >> may
> >>>>> experience trying to follow along.
> >>>>>
> >>>>> Thanks for acting as RM on this release, Arpad. Lots of great work
> >> since
> >>>>> the last release.  Kudos to all the contributors.
> >>>>>
> >>>>> On Wed, Jan 8, 2020 at 11:56 AM Arpad Boda <aboda@apache.org>
wrote:
> >>>>>
> >>>>>> Hello Apache NiFi community,
> >>>>>>
> >>>>>> I am pleased to call this vote for the source release of Apache
> >> NiFi
> >>>>> MiNiFi
> >>>>>> C++ 0.7.0
> >>>>>>
> >>>>>> The source tar.gz, including signatures, digests, and convenience
> >>>>> binaries.
> >>>>>> can be found at:
> >>>>>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/0.7.0/
> >>>>>>
> >>>>>> The Git tag is minifi-cpp-0.7.0-RC1
> >>>>>> The Git commit ID is: aa42957a2e227df41510047cece3cd606dc1cb6a
> >>>>>>
> >>>>>> Checksum of nifi-minifi-cpp-0.7.0-source.tar.gz:
> >>>>>> SHA256:
> >>>> 2a3743e809652b429f3780e616373977fb1884330adabc1430449551b6e247bc
> >>>>>> SHA512:
> >>>>>>
> >>>>>
> >>>>
> >>
> cfa86cb3e34e1e2dc439ade2c0c389c70679a6403ebcc2befb6781995179cac3f4a8ec0e107204bcdd95f2cc6b5be67b2a7fcfe68eb87f561f209074b45fd507
> >>>>>>
> >>>>>> Release artifacts are signed with the following key:
> >>>>>> https://people.apache.org/keys/committer/aboda.asc
> >>>>>>
> >>>>>> KEYS file available here:
> >>>>>> https://dist.apache.org/repos/dist/release/nifi/KEYS
> >>>>>>
> >>>>>> 144 issues were closed/resolved for this release:
> >>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344866&projectId=12321520
> >>>>>>
> >>>>>> Release note highlights can be found here:
> >>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>
> https://cwiki.apache.org/confluence/display/MINIFI/Release+Notes#ReleaseNotes-Versioncpp-0.7.0
> >>>>>>
> >>>>>> The vote will be open for 72 hours.
> >>>>>> Please download the release candidate and evaluate the necessary
> >> items
> >>>>>> including checking hashes, signatures, build
> >>>>>> from source, and test. Then please vote:
> >>>>>>
> >>>>>> [ ] +1 Release this package as nifi-minifi-cpp-0.7.0
> >>>>>> [ ] +0 no opinion
> >>>>>> [ ] -1 Do not release this package because...
> >>>>>>
> >>>>>
> >>>>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message