From dev-return-20054-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Wed Oct 30 19:26:39 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EA1FC180654 for ; Wed, 30 Oct 2019 20:26:38 +0100 (CET) Received: (qmail 61538 invoked by uid 500); 30 Oct 2019 19:26:38 -0000 Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list dev@nifi.apache.org Received: (qmail 61526 invoked by uid 99); 30 Oct 2019 19:26:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Oct 2019 19:26:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 28663C227B for ; Wed, 30 Oct 2019 19:26:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.203 X-Spam-Level: X-Spam-Status: No, score=0.203 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=adamtaft-com.20150623.gappssmtp.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id v6u5fdQJrcxa for ; Wed, 30 Oct 2019 19:26:35 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::330; helo=mail-wm1-x330.google.com; envelope-from=adam@adamtaft.com; receiver= Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id C3A467DD8A for ; Wed, 30 Oct 2019 19:26:34 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id c22so3446088wmd.1 for ; Wed, 30 Oct 2019 12:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamtaft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=P5QbUDQAyRowHmGo6sLell2djqbFdlubsFIcAtOj2iw=; b=VmMA+qYNBPi1bndrsHY2/a1NCf5Pu8Gy6183c+o1x6tvurp2lzJWnAJI1B78dNOXmF koS1fdWI9ppTVMo6ko50kVSf1XrnTurwFVhbPzeg7+m3zqIH12ZfrAGCq6WVdAZjU0qI Nt6ufJ028hNbWHgk/3m2d1mUUPfYGD6P6tqbxM6bNbOKBOlZ4Gyf5HBSYJy3bLbf5OiV 2Uhc/ovVi5mhfaAX6VqDzXpDiC9tP44ku9GcMkYOPro3CHZSuoCOjzJXtLBPjAtJzDi3 FK1btjPhJGyLiiKBVriQ+XaWq0xAZWINHIkVARL7Wd3ixZJueEZJsfGgNoczr+ILJgfe Kdlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=P5QbUDQAyRowHmGo6sLell2djqbFdlubsFIcAtOj2iw=; b=Bf87vDKb/hAwjyOGxJI2BMf2ACIczPjp1EGw2G5Hy2MooSmRnFnj1h+OHlKcq0/ia5 +IQtWfXB4PF4EN6F8eNBcC2PnDHRfBS+D7ThycLkw1LfLR8uTUDrt5ra7Vt2aMqF6Odo TNdZ2axsGKZbM3pXXQeSCtwfggugQxkvZFib3nHu729aeM1HABjVnN+dt02ysoScxU8j kjgsUMfoiuLWJNDl45KJ4yTVC8qDuFlREwo+7MU576BxlIkjEc4CWIwYBwK80h748O0o CGC+9bue6pjkjAUfHrcwG/VvNoaGX9+9105WbF6I4XpZ4U90q6gEmIul1BqHodnVo8uh WquQ== X-Gm-Message-State: APjAAAVfi6vV3P2OBNXE0YBrvo+ahjVmxGto6ofc3uDD0dAwWBbVN+Vv pxgMgMY2moMQa9ZaakKgAwTTradCvYSlsF2XKK0eAtwS2oA= X-Google-Smtp-Source: APXvYqxjfJv3P5Q1WQutjJZV5s+s2bOCJRcWo7ThbHrdE86XIvw4WMSAYv8V8cEOYeydx7RaaPUx5kfL4Rm4VYlEX3Q= X-Received: by 2002:a1c:f20e:: with SMTP id s14mr1022390wmc.118.1572463587770; Wed, 30 Oct 2019 12:26:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adam Taft Date: Wed, 30 Oct 2019 13:25:51 -0600 Message-ID: Subject: Re: Java 11 Compilation To: dev@nifi.apache.org Content-Type: multipart/alternative; boundary="000000000000925d73059625b5f7" --000000000000925d73059625b5f7 Content-Type: text/plain; charset="UTF-8" Right, I agree with your perspective. Just note, however, that this stance will require the RM to create the 1.x convenience binary with Java 8 only. It will be incumbent on the RM to ensure they build with Java 8, because if they accidentally build with Java 11, the binary distribution won't run on Java 8. Adam On Wed, Oct 30, 2019 at 11:56 AM Joe Witt wrote: > Adam > > Interesting. Id say though that where we are now for nifi 1.x is perfect. > That matrix you shared as currently working seems ideal. > > For nifi 2.x we cut bait on Java 8 and go with latest stable Java at that > time (11, 13) > > thanks > > On Wed, Oct 30, 2019 at 12:51 PM Adam Taft wrote: > > > While building 1.10.0-rc3, I wanted to experiment with the compilation > and > > runtime variants using Java 8 and Java 11. The summary of this > experiment > > was: > > > > Comp: Java 8 Run: Java 8 => SUCCESS > > Comp: Java 8 Run: Java 11 => SUCCESS > > Comp: Java 11 Run: Java 8 => FAILURE > > Comp: Java 11 Run: Java 11 => SUCCESS > > > > As introduced in JEP-247 [1], starting with Java 9, javac has the ability > > to compile to an older Java platform. This was not possible previously > > without having multiple JDKs installed and specifying the > '-bootclasspath' > > option in javac for your target. > > > > The newly introduced "--release" option to Java 9+ javac allows you to > > specify the target version using the documented API for that platform. > > This means replacing the '-source' and '-target' parameters with the > > '--release' option instead. > > > > In maven, that manifests itself as a configuration option to the > > maven-compiler-plugin, which is the 'maven.compiler.release' property. > [2] > > > > The discussion here would be consideration for using the "release" option > > as opposed to our current setup which uses "source" and "target". The > > benefit would be that all the deployment scenarios (above) could result > in > > success. > > > > The downside though is that, without other changes, Java 11 would be > > required to compile NiFi. It would still target Java 8 as a supported > > runtime (specifying "release=8"), but you'd have to build/compile with > Java > > 11. I don't think this should be a problem, but it's worth discussion. > > > > Thanks, > > Adam > > > > [1] https://openjdk.java.net/jeps/247 > > [2] > > > > > https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release > > > --000000000000925d73059625b5f7--