From dev-return-19292-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Tue Jun 11 20:43:18 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 75B1B180627 for ; Tue, 11 Jun 2019 22:43:18 +0200 (CEST) Received: (qmail 61433 invoked by uid 500); 11 Jun 2019 20:43:17 -0000 Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list dev@nifi.apache.org Received: (qmail 61421 invoked by uid 99); 11 Jun 2019 20:43:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2019 20:43:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8779BC7893 for ; Tue, 11 Jun 2019 20:43:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.5 X-Spam-Level: ** X-Spam-Status: No, score=2.5 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id IE3kb8pQEqjE for ; Tue, 11 Jun 2019 20:43:11 +0000 (UTC) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 5797C5F19D for ; Tue, 11 Jun 2019 20:43:11 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id p1so5619142plo.2 for ; Tue, 11 Jun 2019 13:43:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=RLM/iiBzwxqs/vhhyD01ZfQiwBq+hkOtGsrNcCqnjkA=; b=cPxgzZWpPJzuG/1FKQjOMM05SvgDEvn4jTlFTm/LuVOpFX+Zv2KRkr3Bt5ydbI5LBt ohE85stXo2/4i++rHK1srhpnioltbjXOc+mwPxxT34cQDeNE06BX6ahwQTjaSYapG1qs DNqf1XvxnD8SqnDtUUxeMg+mIOofhr45fX6DE4KxOEtlWMju5Z7xBTzv6F9uNpy9x+LC E457CHcFkGj5dSDqMvU6W25Ipp4LwgzPWxSBZ7hzgDuie5X0RYkf0iRXGXprlau5CMoG 0BeqsIydkC+/Thp0LEUuZ4E8BaVZISNG3rt5DL3fAKgnN+z73g9st4shS/3E2wXDoWkG mszQ== X-Gm-Message-State: APjAAAWOVGy56bTrri4HRewJE0o0X+Z6WfT8xESmDK9JLpgtsxIf2w0v 0o6E98z5LXFupFkJAU0cuYn7kN8G X-Google-Smtp-Source: APXvYqwaX9WxFvmJ4td/JYV7ROqWiJrQEoDbdmjS9NKMwy6U/zVe7Uh7Ziw8VW2bVVu5rZG+hSUiZw== X-Received: by 2002:a17:902:740c:: with SMTP id g12mr23648233pll.128.1560285783552; Tue, 11 Jun 2019 13:43:03 -0700 (PDT) Received: from [10.137.0.138] ([185.152.67.57]) by smtp.gmail.com with ESMTPSA id c6sm22367741pfm.163.2019.06.11.13.43.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jun 2019 13:43:02 -0700 (PDT) From: Andy LoPresto Content-Type: multipart/alternative; boundary="Apple-Mail=_FC74706B-338F-4358-A840-3492C11D794B" Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [EXT] Re: GitHub Stuff Date: Tue, 11 Jun 2019 13:43:01 -0700 References: <2FADAB41-34A4-477C-965B-8C67CFD57B8A@apache.org> To: dev@nifi.apache.org In-Reply-To: Message-Id: <61F9ED66-6EC3-42FB-97F5-3992729EFA13@apache.org> X-Mailer: Apple Mail (2.3445.102.3) --Apple-Mail=_FC74706B-338F-4358-A840-3492C11D794B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Peter,=20 If you have specific issues setting it up, I=E2=80=99m happy to help = debug. I haven=E2=80=99t done it recently but am willing to investigate = with you.=20 Andy LoPresto alopresto@apache.org alopresto.apache@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Jun 11, 2019, at 12:55 PM, Bryan Bende wrote: >=20 > I will admit I've never setup GPG signing on Linux. I'm sure there are > some additional challenges there. >=20 > Not sure if it is helpful, but there are a few things related to Linux > that are mentioned on this Github page: >=20 > https://help.github.com/en/articles/telling-git-about-your-signing-key >=20 >=20 > On Tue, Jun 11, 2019 at 3:45 PM Kevin Doran wrote: >>=20 >> Yep, I support these suggestions. >>=20 >> Setting up GPG does have a learning curve for folks that haven't done >> it before, but I think our community would be helpful in assisting >> folks on the mailing list and Apache NiFi Slack where they run into >> trouble. It's a good practice to learn and once setup there's not = much >> more to do to get the benefits of it. >>=20 >> Setting up GPG is also required when acting as release manager in >> order to sign convenience binaries (and soon, as Andy brought up, >> maven release artifacts as well - I think that is also a good idea), >> so the effort required to get setup for GPG has lots of benefits for >> folks that are interested in RM'ing as well. >>=20 >> Kevin >>=20 >> On Tue, Jun 11, 2019 at 3:30 PM Peter Wicks (pwicks) = wrote: >>>=20 >>> I like having signed commits. I develop on both Windows and Linux, = but have only had success getting signing working on Windows (which was = a bit complicated as it was). You can see when I switched from mostly = Windows to mostly Linux by when I stopped signing commits... >>>=20 >>> Thanks, >>> Peter >>>=20 >>> -----Original Message----- >>> From: Andy LoPresto >>> Sent: Tuesday, June 11, 2019 1:25 PM >>> To: dev@nifi.apache.org >>> Subject: [EXT] Re: GitHub Stuff >>>=20 >>> I strongly support both of these suggestions. Thanks for starting = the conversation Bryan. GPG signing is very important for security and = for encouraging the rest of the community to adopt these practices as = well. >>>=20 >>>=20 >>> Andy LoPresto >>> alopresto@apache.org >>> alopresto.apache@gmail.com >>> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 >>>=20 >>>> On Jun 11, 2019, at 11:42 AM, Bryan Bende wrote: >>>>=20 >>>> I had two thoughts related to our GitHub usage that I wanted to = throw >>>> out there for PMC members and committers... >>>>=20 >>>> 1) I think it would be helpful if everyone setup the link between >>>> their Apache id and github [1]. Setting up this link puts you into = the >>>> nifi-committers group in Apache (currently 17 of us are in there), = and >>>> I believe this is what controls the list of users that can be = selected >>>> as a reviewer on a pull request. Since PRs are the primary form of >>>> contribution, it would be nice if all of the PMC/committers were in >>>> the reviewer list, but of course you can continue to commit against >>>> Gitbox without doing this. >>>>=20 >>>> 2) I also think it would be nice if most of the commits in the repo >>>> were signed commits that show up as "Verified" in GitHub [2]. Right >>>> now I think we lose the verification if the user reviewing the = commit >>>> doesn't have signing setup, because when you amend the commit to = add >>>> "This closes ...", it technically produces a new commit hash, thus >>>> making the original signature no longer apply (at least this is = what I >>>> think is happening, but other may know more). >>>>=20 >>>> These are obviously just my opinions and no one has to do these >>>> things, but just thought I would throw it out there for discussion = in >>>> case anyone wasn't aware. >>>>=20 >>>> -Bryan >>>>=20 >>>> [1] >>>> = https://nam01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgitb >>>> = ox.apache.org%2Fsetup%2F&data=3D02%7C01%7Cpwicks%40micron.com%7Cc2f2 >>>> = 0a00f6424597c10708d6eea27d65%7Cf38a5ecd28134862b11bac1d563c806f%7C0%7C >>>> = 0%7C636958778999592924&sdata=3DmJ59FD6KSYn1jXHN0yRRagKf6BHdWn7N1ZXmV >>>> 4BtBi8%3D&reserved=3D0 [2] >>>> = https://nam01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fhelp >>>> = .github.com%2Fen%2Farticles%2Fsigning-commits&data=3D02%7C01%7Cpwick >>>> = s%40micron.com%7Cc2f20a00f6424597c10708d6eea27d65%7Cf38a5ecd28134862b1 >>>> = 1bac1d563c806f%7C0%7C0%7C636958778999592924&sdata=3D%2BiByT0SfcxSsoL >>>> XgS4VFLI1DTBn9BW3vD1iPvCCqRSI%3D&reserved=3D0 >>>=20 --Apple-Mail=_FC74706B-338F-4358-A840-3492C11D794B--