nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre Villard <pierre.villard...@gmail.com>
Subject Re: [CANCEL][VOTE] Release Apache NiFi 1.6.0 RC1
Date Mon, 26 Mar 2018 06:11:22 GMT
Hi,

I didn't do a "proper" review, but I built the PR and it does fix the issue
on my side.

Pierre


Le dim. 25 mars 2018 à 18:21, Bryan Bende <bbende@gmail.com> a écrit :

> I plan to review/test the fix that Sivaprasanna made first thing tomorrow
> morning, unless someone gets to it before then.
>
> > On Mar 25, 2018, at 10:29 AM, Joey Frazee <joey.frazee@icloud.com>
> wrote:
> >
> > Joe, yes, referring to what Bryan discovered.
> >
> > On Mar 25, 2018, 9:23 AM -0500, Joe Witt <joe.witt@gmail.com>, wrote:
> >> Team
> >>
> >> RC1 vote is cancelled to correct findings of vote process.
> >>
> >> Joey:
> >> I pushed the RC1 branch
> >> https://github.com/apache/nifi/tree/NIFI-4995-RC1 as per release
> >> guide. We will push the actual tag once we get to a release point.
> >>
> >> Can you clarify what fingerprint issue you are referring to? Just
> >> want to make sure this is what BryanB pointed out and not something
> >> else.
> >>
> >> Thanks
> >> Joe
> >>
> >> On Sun, Mar 25, 2018 at 10:12 AM, Joey Frazee <joey.frazee@icloud.com>
> wrote:
> >>> -1
> >>>
> >>> Ran through the usual release helper stuff, but it seems like the
> fingerprint issue is going to cause problems, so not sure how useful
> putting 1.6.0 out there will be if 1.6.1 will have to be turned around
> immediately.
> >>>
> >>> Did you mean to say there's a nifi-1.6.0 -RC tag? It doesn't look like
> the tag got pushed.
> >>>
> >>> -joey
> >>>
> >>> On Mar 24, 2018, 12:38 AM -0500, Pierre Villard <
> pierre.villard.fr@gmail.com>, wrote:
> >>>> -1 (binding)
> >>>>
> >>>> I confirm the issue mentioned by Bryan. That's actually what Matt and
> I
> >>>> experienced when trying the PR about the S2S Metrics Reporting task
> [1]. I
> >>>> thought it was due to my change but it appears it's not the case.
> >>>>
> >>>> [1] https://github.com/apache/nifi/pull/2575
> >>>>
> >>>> 2018-03-23 22:53 GMT+01:00 Bryan Bende <bbende@gmail.com>:
> >>>>
> >>>>> After voting I happened to be using the RC to test something else
and
> >>>>> came across a bug that I think warrants changing my vote to a -1.
> >>>>>
> >>>>> I created a simple two node cluster and made a standard convert
> record
> >>>>> flow. When I ran the flow I got a schema not found exception, so
I
> >>>>> used the debugger which showed AvroSchemaRegistry had no schemas,
> even
> >>>>> though there was one in the UI.
> >>>>>
> >>>>> I then used the debugger to make sure the onPropertyModified was
> >>>>> getting when a schema was added, and it was which meant some after
> >>>>> adding the schema but before running the flow, it was being removed.
> >>>>>
> >>>>> As far as I can tell, the issue is related to changes introduced
in
> >>>>> NIFI-4864... the intent here was for components with property
> >>>>> descriptors that have "dynamically modifies classpath" to be able
to
> >>>>> smartly reload when they are started based on knowing if more
> >>>>> classpath resources were added.
> >>>>>
> >>>>> The issue is that for components that don't have any property
> >>>>> descriptors like this, they have a null fingerprint, and before
> >>>>> starting it compares null to the fingerprint of empty string, and
> >>>>> decides to reload [2].
> >>>>>
> >>>>> I think the fix should be fairly easy to just short-circuit at the
> >>>>> beginning of that method and return immediately if
> >>>>> additionalResourcesFingerprint is null, but will have to do some
> >>>>> testing.
> >>>>>
> >>>>> [1] https://issues.apache.org/jira/browse/NIFI-4864
> >>>>> [2] https://github.com/apache/nifi/blob/master/nifi-nar-
> >>>>> bundles/nifi-framework-bundle/nifi-framework/nifi-framework-
> >>>>> core-api/src/main/java/org/apache/nifi/controller/
> >>>>> AbstractConfiguredComponent.java#L313-L314
> >>>>>
> >>>>>
> >>>>> On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman <
> matt.c.gilman@gmail.com
> >>>>> wrote:
> >>>>>> +1 (binding) Release this package as nifi-1.6.0
> >>>>>>
> >>>>>> Executed the release helper and verified new granular restrictions
> with
> >>>>>> regards to flow versioning.
> >>>>>>
> >>>>>> Thanks for RMing Joe!
> >>>>>>
> >>>>>> Matt
> >>>>>>
> >>>>>> On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser <moser.mw@gmail.com
> >>>>> wrote:
> >>>>>>
> >>>>>>> +1 (binding)
> >>>>>>>
> >>>>>>> Ran through release helper to verify the release and run
NiFi on
> Ubuntu
> >>>>>>> 16.04. It worked as expected with no new comments to add.
> >>>>>>>
> >>>>>>> -- Mike
> >>>>>>>
> >>>>>>>
> >>>>>>> On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan <
> scottyaslan@gmail.com
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> +1 (binding)
> >>>>>>>>
> >>>>>>>> - Ran through release helper
> >>>>>>>> - Setup secure NiFi and verified a test flow
> >>>>>>>>
> >>>>>>>> On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bbende@gmail.com
> >>>>> wrote:
> >>>>>>>>
> >>>>>>>>> +1 (binding)
> >>>>>>>>>
> >>>>>>>>> - Ran through release helper and everything checked
out
> >>>>>>>>> - Verified some test flows with the restricted components
+
> keytab
> >>>>> CS
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <
> markap14@hotmail.com
> >>>>>>>> wrote:
> >>>>>>>>>> +1 (binding)
> >>>>>>>>>>
> >>>>>>>>>> Was able to verify hashes, build with contrib-check,
and start
> up
> >>>>>>>>> application. Performed some basic functionality
tests and all
> >>>>> worked as
> >>>>>>>>> expected.
> >>>>>>>>>>
> >>>>>>>>>> Thanks!
> >>>>>>>>>> -Mark
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma
<
> >>>>>>> tasanuma@yahoo-corp.jp
> >>>>>>>>>
> >>>>>>>>> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>> Thanks for all your efforts, Joe.
> >>>>>>>>>>>
> >>>>>>>>>>> I have one question. The version of the
generated package is
> >>>>>>>>> nifi-1.7.0-SNAPSHOT. Is this correct at this stage?
If it's ok,
> >>>>>>>>> +1(non-binding).
> >>>>>>>>>>>
> >>>>>>>>>>> - Succeeded "mvn -T 2.0C clean install -DskipTests
-Prpm"
> >>>>>>>>>>> - Started secure cluster mode
> >>>>>>>>>>> - Verified sample dataflows work fine
> >>>>>>>>>>> - Verified the whitelist feature(NIFI-4761)
works fine
> >>>>>>>>>>>
> >>>>>>>>>>> -Takanobu Asanuma
> >>>>>>>>>>>
> >>>>>>>>>>> -----Original Message-----
> >>>>>>>>>>> From: Joe Witt [mailto:joewitt@apache.org]
> >>>>>>>>>>> Sent: Friday, March 23, 2018 1:12 AM
> >>>>>>>>>>> To: dev@nifi.apache.org
> >>>>>>>>>>> Subject: [VOTE] Release Apache NiFi 1.6.0
> >>>>>>>>>>>
> >>>>>>>>>>> Hello,
> >>>>>>>>>>>
> >>>>>>>>>>> I am pleased to be calling this vote for
the source release of
> >>>>>>> Apache
> >>>>>>>>> NiFi nifi-1.6.0.
> >>>>>>>>>>>
> >>>>>>>>>>> The source zip, including signatures, digests,
etc. can be
> found
> >>>>> at:
> >>>>>>>>>>> https://repository.apache.org/content/repositories/
> >>>>>>> orgapachenifi-1122
> >>>>>>>>>>>
> >>>>>>>>>>> The Git tag is nifi-1.6.0-RC1
> >>>>>>>>>>> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> >>>>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
> >>>>>>>>> 49a71f4740c9fac38958961f78dd3cde874b0e45
> >>>>>>>>>>>
> >>>>>>>>>>> Checksums of nifi-1.6.0-source-release.zip:
> >>>>>>>>>>> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> >>>>>>>>>>> SHA256: 4df6638ec87a5bee12e7978abc6413
> >>>>>>> 7ee5da5fc8c399e34cf34ca1c3720a
> >>>>>>>>> c891
> >>>>>>>>>>> SHA512: 6fa536f9618c6c153c04df5db59913
> >>>>>>> eaf3dd54ae2389368129ac6237f755
> >>>>>>>>> 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7
> >>>>> 934e013a
> >>>>>>>>>>>
> >>>>>>>>>>> Release artifacts are signed with the following
key:
> >>>>>>>>>>> https://people.apache.org/keys/committer/joewitt.asc
> >>>>>>>>>>>
> >>>>>>>>>>> KEYS file available here:
> >>>>>>>>>>> https://dist.apache.org/repos/dist/release/nifi/KEYS
> >>>>>>>>>>>
> >>>>>>>>>>> 135 issues were closed/resolved for this
release:
> >>>>>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >>>>>>>>> projectId=12316020&version=12342422
> >>>>>>>>>>>
> >>>>>>>>>>> Release note highlights can be found here:
> >>>>>>>>>>> https://cwiki.apache.org/confluence/display/NIFI/
> >>>>>>>>> Release+Notes#ReleaseNotes-Version1.6.0
> >>>>>>>>>>>
> >>>>>>>>>>> The vote will be open for 72 hours.
> >>>>>>>>>>> Please download the release candidate and
evaluate the
> necessary
> >>>>>>> items
> >>>>>>>>> including checking hashes, signatures, build from
source, and
> test.
> >>>>>>> The
> >>>>>>>>> please vote:
> >>>>>>>>>>>
> >>>>>>>>>>> [ ] +1 Release this package as nifi-1.6.0
[ ] +0 no opinion [ ]
> >>>>> -1
> >>>>>>> Do
> >>>>>>>>> not release this package because...
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message