Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
From: Otto Fowler <ottobackwards@gmail.com>
In-Reply-To: <CA+WJ-++FGXzJ-K7S+zBcagMHX8Ej5oD920S_M5r=XZ+A3GtfXg@mail.gmail.com>
References: <CAO2EVT6L8qsjVYBC+vowstRvFFaDsdfjSjAA522bgrKSjXcw_A@mail.gmail.com>
 <CAO2EVT6t7z7-8t5mDQsPoXVP+R78vB4ZU=6cdawKxfL5vYGBNw@mail.gmail.com>
 <CAO2EVT7Rnaa-kDsH3Un5gVc5UnDZ-zrvCXb8kgOE90NYAm0EAg@mail.gmail.com>
 <CA+WJ-+K4H+Cm8B-W2rRZOeCxO1zW9T0zHbG4q5XU+-VZzo=Nhg@mail.gmail.com>
 <CAO2EVT7KSaUAD4XZbU_XtkQo08vqqEL_-91zTpT60N+_34jgzA@mail.gmail.com>
 <CA+WJ-+JqghRD__y1SvBjPVCth0mHZ3er7Dm+h26z+qO9s484ag@mail.gmail.com>
 <CAO2EVT4H9h+i3PrSOwE8UDXc53LY4-aoo8MwwyWtfGeF1pfx2A@mail.gmail.com>
 <CAPYoqXR9r1w-cfdJhFvvytNvUjwpYOe4=5zgY1Pm8aST7+PbWw@mail.gmail.com>
 <CAO2EVT5L7U6CyR+Q_QUj9jw8xVpor2p6oU8idp1aqAUvJb8rcA@mail.gmail.com> <CA+WJ-++FGXzJ-K7S+zBcagMHX8Ej5oD920S_M5r=XZ+A3GtfXg@mail.gmail.com>
MIME-Version: 1.0
Date: Fri, 10 Feb 2017 01:34:31 +0100
Message-ID: <CAO2EVT66T=2gZ4tNpdP09StCTcTNJov7--J_i4e2NDwKtsJb9g@mail.gmail.com>
Subject: Re: Build failure on Mac OS X with DS_STORE files
To: dev@nifi.apache.org, Koji Kawamura <ijokarumawak@gmail.com>
Cc: Joe Skora <jskora@gmail.com>
Content-Type: multipart/alternative; boundary=001a114a421ceab97d05482242c1
archived-at: Fri, 10 Feb 2017 00:34:43 -0000

--001a114a421ceab97d05482242c1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I am using 1.8.0_31


I have been able to get a complete good build, but I had to make a few
changes.

On February 9, 2017 at 18:34:48, Koji Kawamura (ijokarumawak@gmail.com)
wrote:

Hi Otto,

Which version of Java are you using?
I remember early version of Java 8 fails to pass the test. Would you
try to update JDK version and build it again?

Thanks,
Koji

On Fri, Feb 10, 2017 at 3:43 AM, Otto Fowler <ottobackwards@gmail.com>
wrote:
> OK, that is good. There very well could be something =E2=80=98special=E2=
=80=99 about what
> I am seeing.
> I am fixing things as I find them. The things that are not working make
> sense to me, in other words I=E2=80=99m not sure how they are not broken =
for
> everyone.
>
> Maybe if I get to the end of it, I=E2=80=99ll post what the patch *would*=
 be?
>
>
> On February 9, 2017 at 11:11:55, Joe Skora (jskora@gmail.com) wrote:
>
> Otto,
>
> I regularly build on a Mac without problems, and I believe a lot of
> contributors do as well.
>
> I haven't run into the .DS_Store issues with NiFi, probably because I
> rarely use Finder to access my build folders.
>
> I don't recall any issues with ScriptingProcessor, but it's been a week
or
> more since I built on the Mac, I can check it tonight.
>
> Regards,
> Joe
>
> On Thu, Feb 9, 2017 at 10:59 AM, Otto Fowler <ottobackwards@gmail.com>
> wrote:
>
>> So,
>>
>> I could have a pr that fixes that problem, but I=E2=80=99m seeing new pr=
oblems
>> now. I can submit the pr then keep looking at the other problems (
> meaning
>> I can submit a pr without having a working complete build, just fixing
> that
>> test ), but I=E2=80=99m not sure how you all handle things like this.
>>
>> I have to ask, does anyone working on NiFi use a mac? The next problems
I
>> have are not with .DS_Store files or anything =E2=80=98mac centric=E2=80=
=99, they are
> with
>> Nashorn Java script types in the ScriptingProcessor tests=E2=80=A6..
>>
>> On February 9, 2017 at 09:19:21, Koji Kawamura (ijokarumawak@gmail.com)
>> wrote:
>>
>> Thanks! Please ping me when the PR is ready.
>>
>> On Thu, Feb 9, 2017 at 11:15 PM, Otto Fowler <ottobackwards@gmail.com>
>> wrote:
>> > Sure - I see what you mean, that is a much better approach.
>> > I will certainly do that.
>> >
>> >
>> >
>> > On February 9, 2017 at 09:02:05, Koji Kawamura (ijokarumawak@gmail.com=
)

>> > wrote:
>> >
>> > Hi Otto,
>> >
>> > Thanks for reporting this. I personally haven't encountered this
>> > issue, but as described here [1], when I opened the directory that the
>> > test uses by Mac Finder application, and changed view as icon and move
>> > the icon position, then a .DS_Store file was created.
>> >
>> > I agree with your workaround and I think we should resolve the issue.
>> > By looking at the usage of that method, such as DBCPConnectionPool, or
>> > JoltTransformJSON, those uses file name filter like this:
>> >
>> > (dir, name) -> name !=3D null && name.endsWith(".jar")
>> >
>> > While filtering out specific .DS_Store works, targeting only name
>> > ending with .jar looks more generic work around.
>> >
>> > Would you mind open a JIRA and send a PR? I'd happy to review!
>> >
>> > Thanks,
>> > Koji
>> >
>> > On Thu, Feb 9, 2017 at 1:20 PM, Otto Fowler <ottobackwards@gmail.com>
>> wrote:
>> >> If it turns out that this *is* something you would like addressed, I
> can
>> >> do
>> >> the jira and the PR
>> >>
>> >>
>> >> On February 8, 2017 at 23:13:16, Otto Fowler (ottobackwards@gmail.com=
)

>> >> wrote:
>> >>
>> >> @Test
>> >> public void testGetURLsForClasspathWithDirectory() throws
>> >> MalformedURLException {
>> >> final String jarFilePath =3D "src/test/resources/TestClassLoaderUtils=
";
>> >> URL[] urls =3D ClassLoaderUtils.getURLsForClasspath(jarFilePath,
>> >> (dir,name)->name.compareTo(".DS_Store") =3D=3D 0, false);
>> >> assertEquals(2, urls.length);
>> >> }
>> >>
>> >>
>> >> resolves the issue, and I am able to build everything.
>> >>
>> >>
>> >> On February 8, 2017 at 22:39:53, Otto Fowler (ottobackwards@gmail.com=
)

>> >> wrote:
>> >>
>> >> Hi,
>> >>
>> >> I=E2=80=99m trying to build master on Mac OS X, following the instruc=
tions
> from
>> >> the
>> >> site linked in the README.md.
>> >>
>> >> My build is failing because the unit test:
>> >> testGetURLsForClasspathWithDirectory
>> >> in TestClassLoaderUtils.
>> >>
>> >> It is trying to URLs from a directory, and is expecting 2, but gets
3,
>> >> because the DS_STORE is detected and has an url built and returned
for
>> it.
>> >>
>> >> The test does not pass in a FileNamesFilter, which could be used to
>> filter
>> >> these files out I suppose.
>> >>
>> >> I am wondering if anyone is building successfully on Mac OS X?
>>

--001a114a421ceab97d05482242c1--