nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Koji Kawamura <ijokaruma...@gmail.com>
Subject Re: Build failure on Mac OS X with DS_STORE files
Date Thu, 09 Feb 2017 23:28:04 GMT
Hi Otto,

Which version of Java are you using?
I remember early version of Java 8 fails to pass the test. Would you
try to update JDK version and build it again?

Thanks,
Koji

On Fri, Feb 10, 2017 at 3:43 AM, Otto Fowler <ottobackwards@gmail.com> wrote:
> OK, that is good.  There very well could be something ‘special’ about what
> I am seeing.
> I am fixing things as I find them.  The things that are not working make
> sense to me,  in other words I’m not sure how they are not broken for
> everyone.
>
> Maybe if I get to the end of it, I’ll post what the patch *would* be?
>
>
> On February 9, 2017 at 11:11:55, Joe Skora (jskora@gmail.com) wrote:
>
> Otto,
>
> I regularly build on a Mac without problems, and I believe a lot of
> contributors do as well.
>
> I haven't run into the .DS_Store issues with NiFi, probably because I
> rarely use Finder to access my build folders.
>
> I don't recall any issues with ScriptingProcessor, but it's been a week or
> more since I built on the Mac, I can check it tonight.
>
> Regards,
> Joe
>
> On Thu, Feb 9, 2017 at 10:59 AM, Otto Fowler <ottobackwards@gmail.com>
> wrote:
>
>> So,
>>
>> I could have a pr that fixes that problem, but I’m seeing new problems
>> now. I can submit the pr then keep looking at the other problems (
> meaning
>> I can submit a pr without having a working complete build, just fixing
> that
>> test ), but I’m not sure how you all handle things like this.
>>
>> I have to ask, does anyone working on NiFi use a mac? The next problems I
>> have are not with .DS_Store files or anything ‘mac centric’, they are
> with
>> Nashorn Java script types in the ScriptingProcessor tests…..
>>
>> On February 9, 2017 at 09:19:21, Koji Kawamura (ijokarumawak@gmail.com)
>> wrote:
>>
>> Thanks! Please ping me when the PR is ready.
>>
>> On Thu, Feb 9, 2017 at 11:15 PM, Otto Fowler <ottobackwards@gmail.com>
>> wrote:
>> > Sure - I see what you mean, that is a much better approach.
>> > I will certainly do that.
>> >
>> >
>> >
>> > On February 9, 2017 at 09:02:05, Koji Kawamura (ijokarumawak@gmail.com)
>> > wrote:
>> >
>> > Hi Otto,
>> >
>> > Thanks for reporting this. I personally haven't encountered this
>> > issue, but as described here [1], when I opened the directory that the
>> > test uses by Mac Finder application, and changed view as icon and move
>> > the icon position, then a .DS_Store file was created.
>> >
>> > I agree with your workaround and I think we should resolve the issue.
>> > By looking at the usage of that method, such as DBCPConnectionPool, or
>> > JoltTransformJSON, those uses file name filter like this:
>> >
>> > (dir, name) -> name != null && name.endsWith(".jar")
>> >
>> > While filtering out specific .DS_Store works, targeting only name
>> > ending with .jar looks more generic work around.
>> >
>> > Would you mind open a JIRA and send a PR? I'd happy to review!
>> >
>> > Thanks,
>> > Koji
>> >
>> > On Thu, Feb 9, 2017 at 1:20 PM, Otto Fowler <ottobackwards@gmail.com>
>> wrote:
>> >> If it turns out that this *is* something you would like addressed, I
> can
>> >> do
>> >> the jira and the PR
>> >>
>> >>
>> >> On February 8, 2017 at 23:13:16, Otto Fowler (ottobackwards@gmail.com)
>> >> wrote:
>> >>
>> >> @Test
>> >> public void testGetURLsForClasspathWithDirectory() throws
>> >> MalformedURLException {
>> >> final String jarFilePath = "src/test/resources/TestClassLoaderUtils";
>> >> URL[] urls = ClassLoaderUtils.getURLsForClasspath(jarFilePath,
>> >> (dir,name)->name.compareTo(".DS_Store") == 0, false);
>> >> assertEquals(2, urls.length);
>> >> }
>> >>
>> >>
>> >> resolves the issue, and I am able to build everything.
>> >>
>> >>
>> >> On February 8, 2017 at 22:39:53, Otto Fowler (ottobackwards@gmail.com)
>> >> wrote:
>> >>
>> >> Hi,
>> >>
>> >> I’m trying to build master on Mac OS X, following the instructions
> from
>> >> the
>> >> site linked in the README.md.
>> >>
>> >> My build is failing because the unit test:
>> >> testGetURLsForClasspathWithDirectory
>> >> in TestClassLoaderUtils.
>> >>
>> >> It is trying to URLs from a directory, and is expecting 2, but gets 3,
>> >> because the DS_STORE is detected and has an url built and returned for
>> it.
>> >>
>> >> The test does not pass in a FileNamesFilter, which could be used to
>> filter
>> >> these files out I suppose.
>> >>
>> >> I am wondering if anyone is building successfully on Mac OS X?
>>

Mime
View raw message