nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joey Frazee <joey.fra...@icloud.com>
Subject Re: [VOTE] Release Apache NiFi 1.1.0 (RC1)
Date Fri, 25 Nov 2016 22:27:32 GMT
-1 (non-binding)

While verifying the LICENSE and NOTICE it occurred to me that some test data that was included
(by me sadly) in TestExtractHL7Attributes is MPL (category B) licensed, which while ok for
binary dependencies is not permitted for source dependencies.

I'll PR and remove these ASAP, but I think a second RC is going to have to happen :(

-joey

> On Nov 25, 2016, at 3:58 PM, Tony Kurc <trkurc@gmail.com> wrote:
> 
> It's not a blocker for me, as it is clearly a config issue versus an actual
> license issue
> 
>> On Nov 25, 2016 4:18 PM, "Koji Kawamura" <ijokarumawak@gmail.com> wrote:
>> 
>> Tony, Joe,
>> 
>> Sorry about the nifi-websocket-bundle Rat check issue, I should have
>> added apache-rat-plugin exclude configuration in its pom.xml like
>> other projects such as nifi-toolkit-tls does.
>> 
>> Created a JIRA for that:
>> https://issues.apache.org/jira/browse/NIFI-3103
>> 
>> I'll send a PR immediately. I hope it doesn't affect voting and
>> releasing process.
>> 
>> Thanks,
>> Koji
>> 
>>> On Sat, Nov 26, 2016 at 1:41 AM, Joe Witt <joe.witt@gmail.com> wrote:
>>> Tony
>>> 
>>> I don't believe I ram contrib-check on Windows or Linux.  I did that on
>> osx.
>>> 
>>> My win environment is win10 home.  Very recent Java 8 amd maven 3.3.9.
>>> 
>>> Thanks
>>> Joe
>>> 
>>>> On Nov 25, 2016 11:36 AM, "Tony Kurc" <trkurc@gmail.com> wrote:
>>>> 
>>>> Joe Witt,
>>>> I'm not able to build on Windows 10, I'm failing a rat check in
>>>> nifi-websocket-services-jetty. Any clue what might be in your
>> environment
>>>> that may make it work for you and not me? (maven 3.3.3, java 1.8.0_91)
>>>> 
>>>> From maven build:
>>>> [INFO] --- apache-rat-plugin:0.11:check (default) @
>>>> nifi-websocket-services-jetty ---
>>>> [INFO] 51 implicit excludes (use -debug for more details).
>>>> [INFO] Exclude: nb-configuration.xml
>>>> [INFO] Exclude: nbactions.xml
>>>> [INFO] Exclude: DEPENDENCIES
>>>> [INFO] Exclude: .github/PULL_REQUEST_TEMPLATE.md
>>>> [INFO] 17 resources included (use -debug for more details)
>>>> [INFO] Rat check: Summary of files. Unapproved: 1 unknown: 1 generated:
>> 0
>>>> approved: 14 licence.
>>>> 
>>>> From rat.txt
>>>> 
>>>> *****************************************************
>>>> Summary
>>>> -------
>>>> Generated at: 2016-11-25T11:27:37-05:00
>>>> Notes: 0
>>>> Binaries: 2
>>>> Archives: 0
>>>> Standards: 15
>>>> 
>>>> Apache Licensed: 14
>>>> Generated Documents: 0
>>>> 
>>>> JavaDocs are generated and so license header is optional
>>>> Generated files do not required license headers
>>>> 
>>>> 1 Unknown Licenses
>>>> 
>>>> *******************************
>>>> 
>>>> Unapproved licenses:
>>>> 
>>>> 
>>>> C:/development/nifi-1.1.0/nifi-nar-bundles/nifi-websocket-bundle/nifi-
>>>> websocket-services-jetty/src/test/resources/certs/localhost.crt
>>>> 
>>>> 
>>>> 
>>>> 
>>>>> On Fri, Nov 25, 2016 at 10:44 AM, Joe Witt <joe.witt@gmail.com>
wrote:
>>>>> 
>>>>> No problem.  Thanks
>>>>> 
>>>>> On Nov 25, 2016 10:42 AM, "Andre" <andre-lists@fucs.org> wrote:
>>>>> 
>>>>> Joe,
>>>>> 
>>>>> The non-binding was more in the sense it is not a show stopper (as I
>>>> don't
>>>>> foresee too many people upgrading that way) but I guess I should have
>>>> made
>>>>> it more explicit. :-)
>>>>> 
>>>>> Regarding SNAPSHOT, my bad... good news is that
>>>>> 
>>>>> nifi.build.revision=1b2b9f1
>>>>> 
>>>>> which happens to be Andy's last commit before the version change.
>>>>> 
>>>>> Testing again with the source packages...
>>>>> 
>>>>> 
>>>>> 
>>>>>> On Sat, Nov 26, 2016 at 2:25 AM, Joe Witt <joe.witt@gmail.com>
wrote:
>>>>>> 
>>>>>> Andre
>>>>>> 
>>>>>> BTW as a member of the PMC your votes are binding.
>>>>>> 
>>>>>> I am not quite sure the state of your snapshot version relative to
>> the
>>>>>> release version.  Definitely worth filing a JIRA and doing further
>>>>>> evaluation.
>>>>>> 
>>>>>> Thanks
>>>>>> Joe
>>>>>> 
>>>>>> On Fri, Nov 25, 2016 at 10:13 AM, Andre <andre-lists@fucs.org>
>> wrote:
>>>>>>> Joe,
>>>>>>> 
>>>>>>> -0 (non-binding)
>>>>>>> 
>>>>>>> When testing "rolling upgrade" I noticed that as nodes restarted
>> they
>>>>>> were
>>>>>>> given new Node Ids (I suspect the NodeId is related to the version
>>>> they
>>>>>>> run?). This results on a cluster with 50% of nodes showing up
as
>>>>>>> disconnected.
>>>>>>> 
>>>>>>> 
>>>>>>> Not sure if this is particular to my test environment but would
be
>>>>> great
>>>>>> if
>>>>>>> someone try to reproduce:
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> On a working 3 node secure cluster with embedded zookeeper and
>> "easy
>>>>>>> upgrades directory structure":
>>>>>>> 
>>>>>>> - Untar nifi snapshot
>>>>>>> - mv the output to under /path/to/nifi/
>>>>>>> 
>>>>>>> you should now have
>>>>>>> 
>>>>>>> /path/to/nifi/config
>>>>>>> /path/to/nifi/nifi-1.0.0
>>>>>>> /path/to/nifi/nifi-1.1.0-SNAPSHOT
>>>>>>> 
>>>>>>> - ensure permissions of nifi-1.1.0-SNAPSHOT are correct (i.e.
>> chown,
>>>>>> chmod,
>>>>>>> etc)
>>>>>>> - cd nifi-1.1.0-SNAPSHOT
>>>>>>> - move original nifi config: mv conf conf.old
>>>>>>> - ln -s ../config conf
>>>>>>> 
>>>>>>> - stop old nifi /path/to/nifi/nifi-1.0.0/bin/nifi.sh stop
>>>>>>> 
>>>>>>> - edit /path/to/nifi/config so that nifi.version is set to
>>>>> 1.1.0-SNAPSHOT
>>>>>>> 
>>>>>>> - start new nifi  /path/to/nifi/nifi-1.1.0-SNAPSHOT/bin/nifi.sh
>>>> start
>>>>>>> 
>>>>>>> 
>>>>>>> NiFi should start working but 3/6 nodes will show as down,
>> preventing
>>>>>>> modifications to the data flow.
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> Cheers
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> On Thu, Nov 24, 2016 at 6:04 PM, Joe Witt <joewitt@apache.org>
>>>> wrote:
>>>>>>> 
>>>>>>>> Hello Apache NiFi Community,
>>>>>>>> 
>>>>>>>> I am pleased to be calling this vote for the source release
of
>>>> Apache
>>>>>> NiFi,
>>>>>>>> nifi-1.1.0.
>>>>>>>> 
>>>>>>>> The source zip, including signatures, digests, etc. can be
found
>> at:
>>>>>>>>  https://repository.apache.org/content/repositories/
>>>>> orgapachenifi-1092
>>>>>>>> 
>>>>>>>> The Git tag is nifi-1.1.0-RC1
>>>>>>>> The Git commit hash is 1b2b9f136df73a8b0d5d21419b6ebc2206f78393
>>>>>>>> * https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
>>>>>>>> 1b2b9f136df73a8b0d5d21419b6ebc2206f78393
>>>>>>>> * https://github.com/apache/nifi/commit/
>>>>> 1b2b9f136df73a8b0d5d21419b6ebc
>>>>>>>> 2206f78393
>>>>>>>> 
>>>>>>>> Checksums of nifi-1.1.0-source-release.zip:
>>>>>>>> MD5: b7a83412a088634835f6510974282408
>>>>>>>> SHA1: c538fedf990250dbd75090d7f03aeb2554802c8d
>>>>>>>> SHA256: 39dc521230c9936f9178b9fe34a410
>>>> b932cf0d0807db4aeba9a1b4105102
>>>>>> 3ec6
>>>>>>>> 
>>>>>>>> Release artifacts are signed with the following key:
>>>>>>>>  https://people.apache.org/keys/committer/joewitt
>>>>>>>> 
>>>>>>>> KEYS file available here:
>>>>>>>>  https://dist.apache.org/repos/dist/release/nifi/KEYS
>>>>>>>> 
>>>>>>>> 265 issues were closed/resolved for this release:
>>>>>>>>  https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>>>>>>> projectId=12316020&version=12337875
>>>>>>>> 
>>>>>>>> Release note highlights can be found here:
>>>>>>>>  https://cwiki.apache.org/confluence/display/NIFI/
>>>>>>>> Release+Notes#ReleaseNotes-Version1.1.0
>>>>>>>> 
>>>>>>>> The vote will be open for 88 hours (a bit longer than usual
due
>> to
>>>>>> timing).
>>>>>>>> 
>>>>>>>> Please download the release candidate and evaluate the necessary
>>>> items
>>>>>>>> including checking hashes, signatures, build from source,
and
>> test.
>>>>> Then
>>>>>>>> please vote:
>>>>>>>> 
>>>>>>>> [ ] +1 Release this package as nifi-1.1.0
>>>>>>>> [ ] +0 no opinion
>>>>>>>> [ ] -1 Do not release this package because...
>>>>>>>> 
>>>>>>>> Thanks!
>>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>> 

Mime
View raw message