Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
From: JPercivall <git@git.apache.org>
To: dev@nifi.apache.org
Reply-To: dev@nifi.apache.org
References: <git-pr-21-nifi-minifi@git.apache.org>
In-Reply-To: <git-pr-21-nifi-minifi@git.apache.org>
Subject: [GitHub] nifi-minifi pull request #21: MINIFI-41 - CLI utility for template.xml -> YA...
Content-Type: text/plain
Message-Id: <20160630175224.DCDE4DFF03@git1-us-west.apache.org>
Date: Thu, 30 Jun 2016 17:52:24 +0000 (UTC)
archived-at: Thu, 30 Jun 2016 17:52:26 -0000

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/21#discussion_r69178841
  
    --- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/BaseSchema.java ---
    @@ -15,13 +15,17 @@
      * limitations under the License.
      */
     
    -package org.apache.nifi.minifi.bootstrap.util.schema.common;
    +package org.apache.nifi.minifi.commons.schema;
     
     import java.lang.reflect.Constructor;
     import java.lang.reflect.InvocationTargetException;
    +import java.util.Collections;
    +import java.util.LinkedHashMap;
     import java.util.LinkedList;
     import java.util.List;
     import java.util.Map;
    +import java.util.Set;
    +import java.util.stream.Collectors;
     
     public class BaseSchema {
    --- End diff --
    
    Right the "Validation Issue helper methods" access the validation issues, which is something every schema will have, so it's good to keep them implemented how they are. 
    
    The "Value Access/Interpretation helper methods" are all methods that do not necessarily rely on the internal representation of each schema but instead are helper methods for accessing/interpreting values. So they can be static.
    
    For toMap I agree that it's good to encourage the use of LinkedHashMap. Maybe a protected method getMap for the schemas to use. Then toMap would be abstract.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---