Return-Path: <dev-return-10717-archive-asf-public=cust-asf.ponee.io@nifi.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 98657200B32
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 23 Jun 2016 21:35:32 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 971E6160A59; Thu, 23 Jun 2016 19:35:32 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 11AD7160A35
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 23 Jun 2016 21:35:31 +0200 (CEST)
Received: (qmail 82042 invoked by uid 500); 23 Jun 2016 19:35:31 -0000
Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@nifi.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@nifi.apache.org>
List-Post: <mailto:dev@nifi.apache.org>
List-Id: <dev.nifi.apache.org>
Reply-To: dev@nifi.apache.org
Delivered-To: mailing list dev@nifi.apache.org
Received: (qmail 82027 invoked by uid 99); 23 Jun 2016 19:35:30 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jun 2016 19:35:30 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id C710DE38B1; Thu, 23 Jun 2016 19:35:30 +0000 (UTC)
From: markap14 <git@git.apache.org>
To: dev@nifi.apache.org
Reply-To: dev@nifi.apache.org
References: <git-pr-572-nifi@git.apache.org>
In-Reply-To: <git-pr-572-nifi@git.apache.org>
Subject: [GitHub] nifi pull request #572: NIFI-2059: Ensure that we properly pass along proxie...
Content-Type: text/plain
Message-Id: <20160623193530.C710DE38B1@git1-us-west.apache.org>
Date: Thu, 23 Jun 2016 19:35:30 +0000 (UTC)
archived-at: Thu, 23 Jun 2016 19:35:32 -0000

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/572#discussion_r68300354
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication/ThreadPoolRequestReplicator.java ---
    @@ -210,6 +212,15 @@ public AsyncClusterResponse replicate(Set<NodeIdentifier> nodeIds, String method
             final Map<String, String> updatedHeaders = new HashMap<>(headers);
             updatedHeaders.put(RequestReplicator.CLUSTER_ID_GENERATION_SEED_HEADER, UUID.randomUUID().toString());
             updatedHeaders.put(RequestReplicator.REPLICATION_INDICATOR_HEADER, "true");
    +
    +        // If the user is authenticated, add them as a proxied entity so that when the receiving NiFi receives the request,
    +        // it knows that we are acting as a proxy on behalf of the current user.
    +        final NiFiUser user = NiFiUserUtils.getNiFiUser();
    +        if (user != null && !user.equals(NiFiUser.ANONYMOUS)) {
    --- End diff --
    
    Good call


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---