Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
From: olegz <git@git.apache.org>
To: dev@nifi.apache.org
Reply-To: dev@nifi.apache.org
References: <git-pr-543-nifi@git.apache.org>
In-Reply-To: <git-pr-543-nifi@git.apache.org>
Subject: [GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor
Content-Type: text/plain
Message-Id: <20160620224036.52DEBDFC6F@git1-us-west.apache.org>
Date: Mon, 20 Jun 2016 22:40:36 +0000 (UTC)
archived-at: Mon, 20 Jun 2016 22:40:38 -0000

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/543#discussion_r67779956
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutTCP.java ---
    @@ -0,0 +1,48 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.standard;
    +
    +import org.apache.nifi.processors.standard.util.TestPutTCPCommon;
    +
    +public class TestPutTCP extends TestPutTCPCommon {
    +
    +    public TestPutTCP() {
    +        super();
    +        ssl = false;
    +    }
    +
    +    @Override
    +    public void configureProperties(String host, int port, String outgoingMessageDelimiter, boolean connectionPerFlowFile, boolean expectValid) {
    +        runner.setProperty(PutTCP.HOSTNAME, host);
    +        runner.setProperty(PutTCP.PORT, Integer.toString(port));
    +        if (outgoingMessageDelimiter != null) {
    +            runner.setProperty(PutTCP.OUTGOING_MESSAGE_DELIMITER, outgoingMessageDelimiter);
    +        }
    +        if (connectionPerFlowFile) {
    +            runner.setProperty(PutTCP.CONNECTION_PER_FLOWFILE, "true");
    +        } else {
    +            runner.setProperty(PutTCP.CONNECTION_PER_FLOWFILE, "false");
    +        }
    --- End diff --
    
    While its a style question you and I did talk about it. You are performing the same thing in both IF and ELSE with value being the only difference, so some may say its to verbose (5 lines vs 1).
    That said, I do like the idea of ```runner.setProperty(PutTCP.CONNECTION_PER_FLOWFILE, String.valueOf(connectionPerFlowFile))```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---