Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B17D0200B2F for ; Sun, 19 Jun 2016 02:36:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AFD82160A63; Sun, 19 Jun 2016 00:36:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EEA00160A50 for ; Sun, 19 Jun 2016 02:36:35 +0200 (CEST) Received: (qmail 76130 invoked by uid 500); 19 Jun 2016 00:36:35 -0000 Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list dev@nifi.apache.org Received: (qmail 76119 invoked by uid 99); 19 Jun 2016 00:36:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Jun 2016 00:36:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A8A6DE01BD; Sun, 19 Jun 2016 00:36:34 +0000 (UTC) From: markap14 To: dev@nifi.apache.org Reply-To: dev@nifi.apache.org References: In-Reply-To: Subject: [GitHub] nifi issue #501: NIFI-1974 - Support Custom Properties in Expression Languag... Content-Type: text/plain Message-Id: <20160619003634.A8A6DE01BD@git1-us-west.apache.org> Date: Sun, 19 Jun 2016 00:36:34 +0000 (UTC) archived-at: Sun, 19 Jun 2016 00:36:36 -0000 Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/501 @YolandaMDavis All looks good with the exception of needed to trim() the filenames and one other thing that i noticed, which is that if multiple properties files are specified and one cannot be loaded, none are loaded. I will create an additional commit just to log this accurately and trim the filename and push this to 0.x. I created a JIRA https://issues.apache.org/jira/browse/NIFI-2057 to address the multiple files better, but I don't want that to hold up the 0.7.0 release or prevent this from making it into 0.7.0. I will merge this as-is with that minor change noted to 0.x. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---