Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EE23B160A3B for ; Wed, 1 Jun 2016 14:48:05 +0200 (CEST) Received: (qmail 89366 invoked by uid 500); 1 Jun 2016 12:48:05 -0000 Mailing-List: contact dev-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list dev@nifi.apache.org Received: (qmail 89355 invoked by uid 99); 1 Jun 2016 12:48:04 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2016 12:48:04 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C1C30E0498; Wed, 1 Jun 2016 12:48:04 +0000 (UTC) From: joewitt To: dev@nifi.apache.org Reply-To: dev@nifi.apache.org References: In-Reply-To: Subject: [GitHub] nifi pull request: NIFI-1899 - Introduce ExtractEmailAttachments processor Content-Type: text/plain Message-Id: <20160601124804.C1C30E0498@git1-us-west.apache.org> Date: Wed, 1 Jun 2016 12:48:04 +0000 (UTC) archived-at: Wed, 01 Jun 2016 12:48:06 -0000 Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/483 Cool! Seems like a great start. Left a couple comments and have a couple question/comments. Might be a good idea to have more flow file attributes on the attachment such as any other information like timing/etc.. associated with the attachment if there are any (if not nevermind). Perhaps there is value in knowing a given attachment is the 2nd attachment out of 4 for example. Also, the attachments could be base64 encoded (i think). If that is right do you know if that mail api you're using will automatically convert them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---