nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brosander <...@git.apache.org>
Subject [GitHub] nifi-minifi pull request #21: MINIFI-41 - CLI utility for template.xml -> YA...
Date Thu, 30 Jun 2016 17:46:39 GMT
Github user brosander commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/21#discussion_r69177842
  
    --- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/BaseSchema.java
---
    @@ -15,13 +15,17 @@
      * limitations under the License.
      */
     
    -package org.apache.nifi.minifi.bootstrap.util.schema.common;
    +package org.apache.nifi.minifi.commons.schema;
     
     import java.lang.reflect.Constructor;
     import java.lang.reflect.InvocationTargetException;
    +import java.util.Collections;
    +import java.util.LinkedHashMap;
     import java.util.LinkedList;
     import java.util.List;
     import java.util.Map;
    +import java.util.Set;
    +import java.util.stream.Collectors;
     
     public class BaseSchema {
    --- End diff --
    
    So those helper methods do access the internal state (validation issues).  I can tweak
them to take that as an argument but it seems like leaving them as instance methods makes
sense for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message