nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JPercivall <...@git.apache.org>
Subject [GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...
Date Tue, 21 Jun 2016 23:09:14 GMT
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/556#discussion_r67969095
  
    --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/image/ExtractImageMetadataTest.java
---
    @@ -37,7 +37,7 @@
         private static String BMP_HEADER = "BMP Header.";
         private static String JPEG_HEADER = "JPEG.";
         private static String GIF_HEADER = "GIF Header.";
    -    private static String PNG_HEADER = "PNG.";
    +    private static String PNG_HEADER = "PNG-";
    --- End diff --
    
    Did the PNG header change when changing version of metadata extractor? If so, does that
constitute breaking backwards compatibility?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message