nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JPercivall <...@git.apache.org>
Subject [GitHub] nifi pull request #548: NIFI-2045 - Removing mqtt message from queue after a...
Date Tue, 21 Jun 2016 21:40:11 GMT
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/548#discussion_r67957184
  
    --- Diff: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
    @@ -288,9 +289,13 @@ public void process(final OutputStream out) throws IOException {
     
                 String transitUri = new StringBuilder(broker).append(mqttMessage.getTopic()).toString();
                 session.getProvenanceReporter().receive(messageFlowfile, transitUri);
    +            String uuid = messageFlowfile.getAttribute(CoreAttributes.UUID.key());
                 session.transfer(messageFlowfile, REL_MESSAGE);
    -            mqttQueue.remove(mqttMessage);
                 session.commit();
    +            if (!mqttQueue.remove(mqttMessage)) {
    --- End diff --
    
    In order to avoid concatenating the Strings in the logger message needlessly, this should
check if warn is enabled too: 
    `... && getLogger().isWarnEnabled()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message