nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JPercivall <...@git.apache.org>
Subject [GitHub] nifi pull request #548: NIFI-2045 - Removing mqtt message from queue after a...
Date Tue, 21 Jun 2016 20:11:51 GMT
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/548#discussion_r67942458
  
    --- Diff: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
    @@ -265,7 +266,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession
session
             transferQueue(session);
         }
     
    -    private void transferQueue(ProcessSession session){
    +    // Protected visibility for unit testing
    +    protected BlockingQueue<MQTTQueueMessage> getMqttQueue() {
    +        return mqttQueue;
    +    }
    +
    +    // Protected visibility for unit testing
    +    protected void transferQueue(ProcessSession session){
    --- End diff --
    
    Instead of making these protected I would prefer to use reflection to reference them.
You can see Oleg and I's discussion on the issue here: https://github.com/apache/nifi/pull/392#discussion_r63536461


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message