nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joewitt <...@git.apache.org>
Subject [GitHub] nifi issue #543: NIFI-1834 Create PutTCP Processor
Date Sat, 18 Jun 2016 02:19:13 GMT
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/543
  
    In my view the demarcator is a good start.  A header and footer could be added later or
even just a header could be added and the demarcator could be considered the footer.  Something
like that.
    
    However, what I do think needs to be considered now is adding a way for the character
set of the demarcator to be expressed explicitly.  Right now it calls demarcator.getBytes()
and that will result in different behavior on different platforms and such string to byte
cases always cause issues when not explicit.  Easy change for sure.  Could also allow the
user to supply a file containing bytes as an another option as well.  Anyway - would do the
simplest approach now which gets this processor in circulation then let usage dictate next
steps.
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message