nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JPercivall <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...
Date Thu, 26 May 2016 16:33:55 GMT
Github user JPercivall commented on the pull request:

    https://github.com/apache/nifi/pull/324#issuecomment-221924674
  
    Ah that is an important distinction in regards to the "after" block but then how come
the that issue wouldn't cause all following tests to fail (since FC.shutdown is never executed)?
    
    The first line of the javadoc on ThreadPoolExecutor.execute() says "Executes the given
task sometime in the future." This means there is no guarantee that any of the threads will
get executed before "countDownCounter" finishes. If it doesn't execute any, and the test fails,
it is due to the system never scheduling the thread and not due to the thing being tested
failing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message