nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] nifi-minifi pull request: MINIFI-30 added changes to the config tr...
Date Wed, 25 May 2016 16:11:59 GMT
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/17#discussion_r64602692
  
    --- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
---
    @@ -428,13 +436,26 @@ private static void addProcessGroup(final Element parentElement,
Map<String, Obj
                 addPosition(element);
                 addTextElement(element, "comment", getValueString(flowControllerProperties,
COMMENT_KEY));
     
    -            Map<String, Object> processorConfig = (Map<String, Object>) topLevelYaml.get(PROCESSOR_CONFIG_KEY);
    -            addProcessor(element, processorConfig);
    +            Collection<Object> processors = (Collection<Object>) topLevelYaml.get(PROCESSORS_KEY);
    +            if (processors != null) {
    +                for (Object processorConfig : processors) {
    +                    addProcessor(element, (Map<String, Object>) processorConfig);
    +                }
    +            }
     
    -            Map<String, Object> remoteProcessingGroup = (Map<String, Object>)
topLevelYaml.get(REMOTE_PROCESSING_GROUP_KEY);
    -            addRemoteProcessGroup(element, remoteProcessingGroup);
    +            Map<String, Object> exfilComponent = (Map<String, Object>) topLevelYaml.get(EXFIL_COMPONENT_KEY);
    +            if ("Site-To-Site".equals(getValueString(exfilComponent, TYPE_KEY))) {
    --- End diff --
    
    minor:  would be nice to make this a constant as it is used in two different places for
checks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message