nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1660 - Enhance the expression language wit...
Date Mon, 23 May 2016 14:46:21 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/303#discussion_r64235176
  
    --- Diff: nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java
---
    @@ -233,6 +233,24 @@ public void testEmbeddedExpressionsAndQuotes() {
         }
     
         @Test
    +    public void testJsonPath() {
    +        final Map<String, String> attributes = new HashMap<>();
    +        attributes.put("json",
    --- End diff --
    
    Would recommend we pull the JSON out into a file in src/test/resources. Having this live
in the codebase makes it very difficult to read & edit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message