nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adamonduty <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1578: Create PutSlack processor
Date Wed, 18 May 2016 18:04:44 GMT
Github user adamonduty commented on the pull request:

    https://github.com/apache/nifi/pull/256#issuecomment-220109946
  
    @rstjohn I agree with @alopresto - the webhook is sensitive. Especially because the links
and content posted on slack are generally internal to teams and trusted, inadvertently exposing
a webhook URL could leave teams open to phishing attacks. And possession of a webhook URL
allows one to post to *any* public channel or direct message any user.
    
    You have a great point about the validator - it should validate *after* the expression
language has been applied to allow for use cases like you describe. I'm a bit on the fence
on assuming a name without a `#` is a channel name though. 
    
    We could also expose the `attachments` section. Did you envision a property where you
could supply a json array as described in <a href="https://api.slack.com/docs/attachments">Slack's
documentation</a>? Or did you have another approach in mind?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message