nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joewitt <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...
Date Fri, 13 May 2016 19:51:20 GMT
Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/430#discussion_r63241497
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
---
    @@ -2527,6 +2554,43 @@ public String toString() {
             return "StandardProcessSession[id=" + sessionId + "]";
         }
     
    +    @Override
    +    public String getUnacknowledgedFlowfileInfo() {
    --- End diff --
    
    I would make this private and have it called by rollback itself for the sole purpose of
writing to the log.  If you want to return something to a client/caller then it should definitely
offer some sort of object model (set of flowfiles) type return rather than a preformatted
string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message