nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joewitt <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...
Date Fri, 13 May 2016 19:02:23 GMT
Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/430#discussion_r63235023
  
    --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
    @@ -21,13 +21,19 @@
     public abstract class AbstractProcessor extends AbstractSessionFactoryProcessor {
     
         @Override
    +    protected void init(ProcessorInitializationContext context) {
    +        super.init(context);
    --- End diff --
    
    This seems like it is unnecessary.  What is this doing?  Even if a subclass implements
their own init they'll need to call super anway, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message