nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scottyaslan <>
Subject [GitHub] nifi pull request: NIFI-1850 - Initial Commit for JSON-to-JSON Sch...
Date Wed, 11 May 2016 15:11:31 GMT
Github user scottyaslan commented on a diff in the pull request:
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-transform-json-ui/src/main/webapp/app/components/processor/processor.service.js
    @@ -0,0 +1,52 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +'use strict';
    +angular.module('standardUI').factory('ProcessorService', function ProcessorService($http)
    --- End diff --
    Angular invokes certain functions (like service factories and controllers) via the injector.
You need to annotate these functions so that the injector knows what services to inject into
the function. Here you have chosen to do so implicitly... If you plan to minify your code
and have used implicit annotations then your service names will get renamed and your angular
app will be broken. To allow the minifiers to rename the function parameters and still be
able to inject the right services, the function needs to be annotated with the $inject property.
You can read more about it here: 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message