nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mcgilman <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1745: Refactor how requests are replicated...
Date Fri, 06 May 2016 19:22:30 GMT
Github user mcgilman commented on the pull request:

    https://github.com/apache/nifi/pull/413#issuecomment-217535825
  
    Turns out I had a deployment problem earlier... 
    
    Anyways, running great after the most recent update. I agree we need to introduce these
changes in stages given the number of moving parts. I've addressed a couple minor issues (URI
paths, .gitignore, etc) which I'll be including in your commit. 
    
    One suggestion for the next portion of this work would be to re-introduce the wiring of
the HTTP Replicator and Response Mapper in the WebClusterManager. While requiring more arguments,
this would ultimately help promote testability rather than hard-coding a particular implementation.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message