nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pvillard31 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1732 Added timeout property to override 30...
Date Fri, 06 May 2016 17:07:44 GMT
Github user pvillard31 commented on the pull request:

    https://github.com/apache/nifi/pull/337#issuecomment-217500797
  
    Thanks @JPercivall 
    Few remarks:
    - when there is a timeout, what I observed is a request with a dispatcher type set to
ERROR (I've never seen ASYNC so far).
    - I was not aware of the cleaning job in the context map, but since the jetty timeout
is 30 seconds, that would explain why the context map is never cleared once jetty starts to
continuously send error dispatch messages.
    
    I am definitely a +1 to remove the property and automatically set the timeout in line
with the context map. It'll prevent strange behavior, and as I said in the JIRA, if the timeout
is not correctly set by the user, we would potentially see the context map filled after a
moment. I'll update the PR accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message