nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bbende <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...
Date Tue, 03 May 2016 02:15:31 GMT
Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/384#discussion_r61832445
  
    --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java
---
    @@ -52,15 +54,27 @@
     @EventDriven
     @InputRequirement(Requirement.INPUT_ALLOWED)
     @Tags({"hive", "sql", "select", "jdbc", "query", "database"})
    -@CapabilityDescription("Execute provided HiveQL SELECT query against a Hive database
connection. Query result will be converted to Avro format."
    +@CapabilityDescription("Execute provided HiveQL SELECT query against a Hive database
connection. Query result will be converted to Avro or CSV format."
             + " Streaming is used so arbitrarily large result sets are supported. This processor
can be scheduled to run on "
             + "a timer, or cron expression, using the standard scheduling methods, or it
can be triggered by an incoming FlowFile. "
             + "If it is triggered by an incoming FlowFile, then attributes of that FlowFile
will be available when evaluating the "
             + "select query. FlowFile attribute 'executehiveql.row.count' indicates how many
rows were selected.")
    -public class ExecuteHiveQL extends AbstractHiveQLProcessor {
    +@WritesAttributes({
    +        @WritesAttribute(attribute = "mime.type", description = "Sets the MIME type for
the outgoing flowfile to application/avro-binary for Avro or text/csv for CSV."),
    +        @WritesAttribute(attribute = "filename", description = "Adds .avro or .csv to
the filename attribute depending on which output format is selected."),
    +        @WritesAttribute(attribute = "executehiveql.row.count", description = "Indicates
how many rows were selected/returned by the query.")
    --- End diff --
    
    Nit-picking here, but given the rename of the processor, do we want this to be selecthiveql.row.count?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message