nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sean Busbey <>
Subject Re: [DISCUSS] git branching model
Date Mon, 04 Apr 2016 23:01:06 GMT
On Mon, Apr 4, 2016 at 4:40 PM, Adam Lamar <> wrote:
> On Mon, Apr 4, 2016 at 11:14 AM, Sean Busbey <> wrote:
>> You're correct, a github PR only targets a single branch and Travis-CI
>> only checks how the PR does at its own commit hash (that is, it
>> doesn't even check what the target branch would look like post-merge).
> Hey Sean, it looks like Travis-CI does merge into the specified merge
> branch before running. For example, my ListS3 PR [1] has commit
> 2f7e89e, but the Travis-CI status page [1] shows commit e0868c2. If
> you find that in github [2] you'll see it is the merge of 2f7e89e and
> 6f5fb59, where 6f5fb59 is the location of master when I submitted the
> PR.

Excellent. I am very happy to find that I'm incorrect. I must just be
used to using Travis-CI with very old PRs. :)

View raw message