nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adamonduty <>
Subject [GitHub] nifi pull request: NIFI-1578: Create PutSlack processor
Date Wed, 27 Apr 2016 04:43:27 GMT
Github user adamonduty commented on a diff in the pull request:
    --- Diff: nifi-nar-bundles/nifi-slack-bundle/nifi-slack-nar/pom.xml ---
    @@ -0,0 +1,41 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +  Licensed to the Apache Software Foundation (ASF) under one or more
    +  contributor license agreements. See the NOTICE file distributed with
    +  this work for additional information regarding copyright ownership.
    +  The ASF licenses this file to You under the Apache License, Version 2.0
    +  (the "License"); you may not use this file except in compliance with
    +  the License. You may obtain a copy of the License at
    +  Unless required by applicable law or agreed to in writing, software
    +  distributed under the License is distributed on an "AS IS" BASIS,
    +  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  See the License for the specific language governing permissions and
    +  limitations under the License.
    +<project xmlns="" xmlns:xsi=""
    +    <modelVersion>4.0.0</modelVersion>
    +    <parent>
    +        <groupId>org.apache.nifi</groupId>
    +        <artifactId>nifi-slack-bundle</artifactId>
    +        <version>0.6.0-SNAPSHOT</version>
    --- End diff --
    I changed these to `1.0.0-SNAPSHOT` so that it builds on master. Is that correct, or should
I be submitting against the `0.x` branch, or should I do both? If so, it seems more natural
to me to submit against master and backport to `0.x`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message