nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] nifi-minifi pull request: MINIFI-17 Adding error handling of confi...
Date Sun, 24 Apr 2016 15:48:43 GMT
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/15#discussion_r60846667
  
    --- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/configuration/notifiers/RestChangeNotifier.java
---
    @@ -227,15 +235,27 @@ public void handle(String target, Request baseRequest, HttpServletRequest
reques
                         }
                     }
                     setConfigFile(configBuilder.substring(0,configBuilder.length()-1));
    -                notifyListeners();
    -                writeOutput(response, POST_TEXT, 200);
    +                ListenerHandleResult[] listenerHandleResults = notifyListeners();
    +
    +                writeOutput(response, getPostText(listenerHandleResults), 200);
    --- End diff --
    
    With the new collection of results, it seems like the returned status code should reflect
the status of the attempted notifications.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message