nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1732 Added timeout property to override 30...
Date Fri, 08 Apr 2016 12:04:20 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/337#discussion_r59014646
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java
---
    @@ -220,6 +221,13 @@
                 .allowableValues(CLIENT_NONE, CLIENT_WANT, CLIENT_NEED)
                 .defaultValue(CLIENT_NONE.getValue())
                 .build();
    +    public static final PropertyDescriptor TIMEOUT = new PropertyDescriptor.Builder()
    +            .name("Timeout")
    +            .description("The timeout to set when handling requests")
    +            .required(false)
    --- End diff --
    
    I typically recommend setting required = true if there is a default value. This is just
because a value will always be present and as a result this flag doesn't really mean a whole
lot. So I use required = true for consistency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message