nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1553: File based authorizer
Date Thu, 07 Apr 2016 19:21:30 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/330#discussion_r58929464
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/authorization/StandardAuthorizerConfigurationContext.java
---
    @@ -44,8 +47,13 @@ public String getIdentifier() {
         }
     
         @Override
    -    public String getProperty(String property) {
    -        return properties.get(property);
    +    public PropertyValue getProperty(String property) {
    +        final String value = properties.get(property);
    +        if (value == null) {
    --- End diff --
    
    In this case, I think we should still be returning a new StandardPropertyValue with a
value of null, rather than returning no PropertyValue at all. This allows us to chain method
calls, such as: Integer x = getProperty(...).asInteger();


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message