nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MINIFI-404) Provide a source build of executables used for Windows or remove functionality
Date Fri, 06 Oct 2017 02:43:02 GMT

    [ https://issues.apache.org/jira/browse/MINIFI-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194060#comment-16194060
] 

ASF GitHub Bot commented on MINIFI-404:
---------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/92#discussion_r143100163
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/pom.xml
---
    @@ -25,6 +25,61 @@
         <description>holds common resources used to build installers</description>
         <build>
             <plugins>
    +        	<plugin>
    +				<groupId>org.apache.maven.plugins</groupId>
    +				<artifactId>maven-antrun-plugin</artifactId>
    +				<dependencies>
    +					<dependency>
    +						<groupId>ant-contrib</groupId>
    +						<artifactId>ant-contrib</artifactId>
    +						<version>20020829</version>
    +					</dependency>
    +				</dependencies>
    +				<executions>
    +					<execution>
    +						<id>download-commons-daemon</id>
    +						<phase>compile</phase>
    +						<goals>
    +							<goal>run</goal>
    +						</goals>
    +						<configuration>
    +							<tasks>
    +								<taskdef resource="net/sf/antcontrib/antcontrib.properties" />
    +								<if>
    +									<available file="${basedir}/src/main/resources/bin/minifiw.exe" />
    +									<then>
    +										<echo message="Skipping download of commons-daemon." />
    +									</then>
    +									<else>
    +										<echo message="Downloading Commons Daemon Windows binaries." />
    +										<get
    +											src="http://www.apache.org/dist/commons/daemon/binaries/windows/commons-daemon-1.0.15-bin-windows.zip"
    +											dest="${java.io.tmpdir}/commons-daemon-1.0.15-bin-windows.zip"
    +											skipexisting="true" />
    +										<get
    +											src="http://www.apache.org/dist/commons/daemon/binaries/windows/commons-daemon-1.0.15-bin-windows.zip.md5"
    +											dest="${java.io.tmpdir}/commons-daemon-1.0.15-bin-windows.zip.md5"
    +											skipexisting="true" />
    +										<local name="checksum.matches" />
    +										<checksum file="${java.io.tmpdir}/commons-daemon-1.0.15-bin-windows.zip"
fileext=".md5" format="MD5SUM" verifyProperty="checksum.matches"/>
    --- End diff --
    
    I might be missing something. From my quick reading of the [checksum tool page](https://ant.apache.org/manual/Tasks/checksum.html),
it looks like they support [any hash algorithm supported by the JRE](http://docs.oracle.com/javase/7/docs/technotes/guides/security/StandardNames.html#MessageDigest)
(SHA-256, SHA-384, and SHA-512 included in Java 7+). 


> Provide a source build of executables used for Windows or remove functionality
> ------------------------------------------------------------------------------
>
>                 Key: MINIFI-404
>                 URL: https://issues.apache.org/jira/browse/MINIFI-404
>             Project: Apache NiFi MiNiFi
>          Issue Type: Task
>          Components: Agent Configuration/Installation
>    Affects Versions: 0.2.0
>            Reporter: Aldrin Piri
>            Assignee: Jeff Zemerick
>            Priority: Blocker
>             Fix For: 0.3.0
>
>
> MINIFI-344 provided windows support making use of the Apache Daemon procrun.  This was
accomplished by making use of those binaries and wrapping the application which is an issue
for a proper source release.  We need to determine a way to generate these at build time (other
Apache projects generate such artifacts and we should evaluate how those are accomplished).
 Should no tenable solution be found before our next release, this will have to be removed
until a time when we are able to.  In such a scenario,  we could capture this information
in docs for those that are interested in doing so out of the community processes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message