nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MINIFI-374) Create integration tests for HTTPS communication
Date Thu, 14 Sep 2017 17:04:00 GMT

    [ https://issues.apache.org/jira/browse/MINIFI-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166603#comment-16166603
] 

ASF GitHub Bot commented on MINIFI-374:
---------------------------------------

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/135
  
    This now gets me past the point where the venv couldn't be created, but seem to be having
issues with the running of the tests themselves.
    ```
     DEBUG:urllib3.connectionpool:http://localhost:None "DELETE /v1.30/networks/9edfa045d1a03039cbf5ee1a1b7622f808d7d31bc3335b637e48726387dddd99
HTTP/1.1" 204 0
    FAILED
    ../docker/test/integration/test_https.py::test_invoke_listen_https_one_way INFO:root:Generating
test certificate request
    ...
    FAILED
    
    ==========================================================================================================================================================
FAILURES ==========================================================================================================================================================
    _____________________________________________________________________________________________________________________________________________________
test_invoke_listen _____________________________________________________________________________________________________________________________________________________
    
        def test_invoke_listen():
            """
            Verify sending using InvokeHTTP to a receiver using ListenHTTP.
            """
    
            invoke_flow = (GetFile('/tmp/input') >> LogAttribute() >>
                           InvokeHTTP('http://minifi-listen:8080/contentListener', method='POST'))
    
            listen_flow = ListenHTTP(8080) >> LogAttribute() >> PutFile('/tmp/output')
    
            with DockerTestCluster(SingleFileOutputValidator('test')) as cluster:
    
                cluster.put_test_data('test')
                cluster.deploy_flow(listen_flow, name='minifi-listen')
                cluster.deploy_flow(invoke_flow, name='minifi-invoke')
    
    >           assert cluster.check_output()
    E           assert False
    E            +  where False = <bound method DockerTestCluster.check_output of <minifi.test.DockerTestCluster
object at 0x106491710>>()
    E            +    where <bound method DockerTestCluster.check_output of <minifi.test.DockerTestCluster
object at 0x106491710>> = <minifi.test.DockerTestCluster object at 0x106491710>.check_output
    
    ../docker/test/integration/test_http.py:36: AssertionError
    ______________________________________________________________________________________________________________________________________________
test_invoke_listen_https_one_way ______________________________________________________________________________________________________________________________________________
    
        def test_invoke_listen_https_one_way():
            """
            Verify sending using InvokeHTTP to a receiver using ListenHTTP (with TLS).
            """
    
            cert, key = gen_cert()
    
            # TODO define SSLContextService class & generate config yml for services
            crt_file = '/tmp/resources/test-crt.pem'
    
            invoke_flow = (GetFile('/tmp/input')
                           >> LogAttribute()
                           >> InvokeHTTP('https://minifi-listen:4430/contentListener',
                                         method='POST',
                                         ssl_context_service=SSLContextService(ca_cert=crt_file)))
    
            listen_flow = (ListenHTTP(4430, cert=crt_file)
                           >> LogAttribute()
                           >> PutFile('/tmp/output'))
    
            with DockerTestCluster(SingleFileOutputValidator('test')) as cluster:
                cluster.put_test_resource('test-crt.pem', cert.as_pem() + key.as_pem(None,
callback))
                cluster.put_test_data('test')
                cluster.deploy_flow(listen_flow, name='minifi-listen')
                cluster.deploy_flow(invoke_flow, name='minifi-invoke')
    
    >           assert cluster.check_output()
    E           assert False
    E            +  where False = <bound method DockerTestCluster.check_output of <minifi.test.DockerTestCluster
object at 0x1065481d0>>()
    E            +    where <bound method DockerTestCluster.check_output of <minifi.test.DockerTestCluster
object at 0x1065481d0>> = <minifi.test.DockerTestCluster object at 0x1065481d0>.check_output
    
    ../docker/test/integration/test_https.py:54: AssertionError
    ============================================================================================================================================
2 failed, 2 passed in 36.37 seconds =============================================================================================================================================
    make[3]: *** [CMakeFiles/docker-verify] Error 1
    make[2]: *** [CMakeFiles/docker-verify.dir/all] Error 2
    make[1]: *** [CMakeFiles/docker-verify.dir/rule] Error 2
    make: *** [docker-verify] Error 2
    ```
    
    Of note, and not sure if this is a contributing factor.  I did rebuild the image.  When
I first evaluated, I believe it was using a cached version of the minifi-cpp built from another
branch.  This isn't necessarily bad, but may be worthwhile to force a new image build with
the current sources for this particular target to ensure we are testing the latest items.


> Create integration tests for HTTPS communication
> ------------------------------------------------
>
>                 Key: MINIFI-374
>                 URL: https://issues.apache.org/jira/browse/MINIFI-374
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>
> Create automated tests to verify that HTTPS communications work as intended. Tests will
need to generate certificates.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message