[ https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159297#comment-16159297
]
ASF GitHub Bot commented on MINIFI-339:
---------------------------------------
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137885309
--- Diff: CMakeLists.txt ---
@@ -35,6 +35,8 @@ ENDIF(POLICY CMP0048)
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-std=c++11 " COMPILER_SUPPORTS_CXX11)
CHECK_CXX_COMPILER_FLAG("-std=c++0x " COMPILER_SUPPORTS_CXX0X)
+SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ")
+SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}")
--- End diff --
Got it. If we add them back, and I understand correctly how this all is working, then
I think we should use distinct vars rather than exact copies of the cmake parameters. Something
like CXX_OPTIMIZATION_FLAGS. I do think optimizations are going to be desirable. I almost
feel like we need some kind of automated/reproducible way to measure things before getting
too fancy with optimizations. I.e. a microbenchmark suite, something to measure bin size,
and something to measure memory usage.
> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
> Key: MINIFI-339
> URL: https://issues.apache.org/jira/browse/MINIFI-339
> Project: Apache NiFi MiNiFi
> Issue Type: New Feature
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Critical
> Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and likely have
public and private elements. As development progresses we may want more capabilities.
> What I want to create as a straw man will be basic control and metrics gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
> ** Throughput of of flow components
> ** Execution time ( run time minus sleep time )
> ** Memory consumption
> -- Drain repositories
> -- Switch repository types.
> Better employ update listener within this controlling API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
|