nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MINIFI-339) Begin building controlling API to facilitate control of agents
Date Fri, 08 Sep 2017 20:39:03 GMT

    [ https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159283#comment-16159283
] 

ASF GitHub Bot commented on MINIFI-339:
---------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137864284
  
    --- Diff: libminifi/include/core/Processor.h ---
    @@ -212,19 +217,35 @@ class Processor : public Connectable, public ConfigurableComponent,
public std::
      public:
     
       // OnTrigger method, implemented by NiFi Processor Designer
    +  virtual void onTrigger(std::shared_ptr<ProcessContext> context, std::shared_ptr<ProcessSession>
session){
    +    onTrigger(context.get(),session.get());
    +  }
       virtual void onTrigger(ProcessContext *context, ProcessSession *session) = 0;
       // Initialize, overridden by NiFi Process Designer
       virtual void initialize() {
       }
       // Scheduled event hook, overridden by NiFi Process Designer
    +  virtual void onSchedule(std::shared_ptr<ProcessContext> context, std::shared_ptr<ProcessSessionFactory>
sessionFactory){
    +    onSchedule(context.get(),sessionFactory.get());
    +  }
       virtual void onSchedule(ProcessContext *context, ProcessSessionFactory *sessionFactory)
{
       }
     
       // Check all incoming connections for work
       bool isWorkAvailable();
     
    +  void setStreamFactory(std::shared_ptr<minifi::io::StreamFactory> stream_factory)
{
    --- End diff --
    
    Why not just require a valid StreamFactory when the object is constructed, and not allow
it to be dynamically changed?


> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
>                 Key: MINIFI-339
>                 URL: https://issues.apache.org/jira/browse/MINIFI-339
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Critical
>              Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and likely have
public and private elements. As development progresses we may want more capabilities. 
> What I want to create as a straw man will be basic control and metrics gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
>    ** Throughput of of flow components
>    ** Execution time ( run time minus sleep time )
>    ** Memory consumption
> -- Drain repositories
> -- Switch repository types. 
> Better employ update listener within this controlling API



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message