nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MINIFI-324) Explore alternative ways to supply identifiers
Date Fri, 23 Jun 2017 13:12:00 GMT

    [ https://issues.apache.org/jira/browse/MINIFI-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060874#comment-16060874
] 

ASF GitHub Bot commented on MINIFI-324:
---------------------------------------

Github user brosander commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123743755
  
    --- Diff: libminifi/src/provenance/Provenance.cpp ---
    @@ -34,9 +36,24 @@ namespace nifi {
     namespace minifi {
     namespace provenance {
     
    +std::shared_ptr<utils::IdGenerator> ProvenanceEventRecord::id_generator_ = utils::IdGenerator::getIdGenerator();
    +std::shared_ptr<logging::Logger> ProvenanceEventRecord::logger_ = logging::LoggerFactory<ProvenanceEventRecord>::getLogger();
    +
     const char *ProvenanceEventRecord::ProvenanceEventTypeStr[REPLAY + 1] = { "CREATE", "RECEIVE",
"FETCH", "SEND", "DOWNLOAD", "DROP", "EXPIRE", "FORK", "JOIN", "CLONE", "CONTENT_MODIFIED",
         "ATTRIBUTES_MODIFIED", "ROUTE", "ADDINFO", "REPLAY" };
     
    +ProvenanceEventRecord::ProvenanceEventRecord(ProvenanceEventRecord::ProvenanceEventType
event, std::__cxx11::string componentId, std::__cxx11::string componentType) {
    --- End diff --
    
    Autocomplete fail, will fix


> Explore alternative ways to supply identifiers
> ----------------------------------------------
>
>                 Key: MINIFI-324
>                 URL: https://issues.apache.org/jira/browse/MINIFI-324
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>            Reporter: marco polo
>            Assignee: Bryan Rosander
>            Priority: Minor
>
> As [~bryanrosander@gmail.com] mentioned, we could either increment a value in place of
generating unique identifiers for any non NiFi related comms ( i.e. internal objects, claims,
etc )
> Generating unique identifiers is costly and this may not be a cost all consumers wish
to incur. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message