nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (MINIFI-258) Avoid using singleton for Configure.
Date Thu, 04 May 2017 14:50:04 GMT


ASF GitHub Bot commented on MINIFI-258:

Github user phrocker commented on a diff in the pull request:
    --- Diff: libminifi/src/io/ClientSocket.cpp ---
    @@ -39,7 +40,7 @@ namespace io {
     char *Socket::HOSTNAME = const_cast<char*>(Socket::getMyHostName(0).c_str());
    -Socket::Socket(const std::string &hostname, const uint16_t port,
    +Socket::Socket(std::shared_ptr<SocketContext> context, const std::string &hostname,
const uint16_t port,
    --- End diff --
    same, may want to pass by const reference here. 

> Avoid using singleton for Configure. 
> -------------------------------------
>                 Key: MINIFI-258
>                 URL:
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++
>            Reporter: marco polo
>            Assignee: Bryan Rosander
> Avoiding a singleton for Configure will allow us to eventually support multiple, disparate
flows. The object FlowConfiguration can be passed with the information in Configure. This
has increased coupling dramatically while also limiting how configurations can be stored within
> It stands to reason that to eventually support C2 activities and to facilitate multiple
configurations, we will need to remove state from the global level and make it something that
is referenced from the objects which care ( proper encapsulation ). 

This message was sent by Atlassian JIRA

View raw message