nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MINIFI-258) Avoid using singleton for Configure.
Date Thu, 04 May 2017 04:11:04 GMT

    [ https://issues.apache.org/jira/browse/MINIFI-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996152#comment-15996152
] 

ASF GitHub Bot commented on MINIFI-258:
---------------------------------------

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/91

    MINIFI-258 - Removing Configure, StreamFactory, TLSContext singletons

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] - N/A - If adding new dependencies to the code, are these dependencies licensed
in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [X] - N/A - If applicable, have you updated the LICENSE file?
    - [X] - N/A - If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [X] - N/A - Have you ensured that format looks appropriate for the output in which it
is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi-minifi-cpp MINIFI-258

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #91
    
----
commit de55683522115a409029bee89fad64c0a407bcf3
Author: Bryan Rosander <brosander@apache.org>
Date:   2017-05-01T18:49:44Z

    MINIFI-258 - Removing Configure, StreamFactory, TLSContext singletons

----


> Avoid using singleton for Configure. 
> -------------------------------------
>
>                 Key: MINIFI-258
>                 URL: https://issues.apache.org/jira/browse/MINIFI-258
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++
>            Reporter: marco polo
>            Assignee: Bryan Rosander
>
> Avoiding a singleton for Configure will allow us to eventually support multiple, disparate
flows. The object FlowConfiguration can be passed with the information in Configure. This
has increased coupling dramatically while also limiting how configurations can be stored within
minifi. 
> It stands to reason that to eventually support C2 activities and to facilitate multiple
configurations, we will need to remove state from the global level and make it something that
is referenced from the objects which care ( proper encapsulation ). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message