nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeremyd...@apache.org
Subject nifi-minifi-cpp git commit: Adding an initial GitHub PR template.
Date Thu, 02 Mar 2017 12:37:42 GMT
Repository: nifi-minifi-cpp
Updated Branches:
  refs/heads/master f38859e43 -> 6f447c8c9


Adding an initial GitHub PR template.

This closes #20

Signed-off-by: Jeremy Dyer <jeremydyer@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/commit/6f447c8c
Tree: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/tree/6f447c8c
Diff: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/diff/6f447c8c

Branch: refs/heads/master
Commit: 6f447c8c98d2ae457a52e2779c57f3de35a48f9f
Parents: f38859e
Author: Aldrin Piri <aldrin@apache.org>
Authored: Wed Oct 19 09:27:48 2016 -0400
Committer: Jeremy Dyer <jeremydyer@apache.org>
Committed: Thu Mar 2 07:28:28 2017 -0500

----------------------------------------------------------------------
 .github/PULL_REQUEST_TEMPLATE.md | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/6f447c8c/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 0000000..f94f345
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,25 @@
+Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
+
+In order to streamline the review of the contribution we ask you
+to ensure the following steps have been taken:
+
+### For all changes:
+- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
+     in the commit message?
+
+- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
+
+- [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)?
+
+- [ ] Is your initial contribution a single, squashed commit?
+
+### For code changes:
+- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that
is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
+- [ ] If applicable, have you updated the LICENSE file?
+- [ ] If applicable, have you updated the NOTICE file?
+
+### For documentation related changes:
+- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
+
+### Note:
+Please ensure that once the PR is submitted, you check travis-ci for build issues and submit
an update to your PR as soon as possible.


Mime
View raw message