Return-Path: <commits-return-31148-archive-asf-public=cust-asf.ponee.io@nifi.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 90205200BCC
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 14 Nov 2016 22:53:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 8ED94160B06; Mon, 14 Nov 2016 21:53:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id B268C160B19
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 14 Nov 2016 22:52:59 +0100 (CET)
Received: (qmail 22401 invoked by uid 500); 14 Nov 2016 21:52:58 -0000
Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@nifi.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@nifi.apache.org>
List-Post: <mailto:commits@nifi.apache.org>
List-Id: <commits.nifi.apache.org>
Reply-To: dev@nifi.apache.org
Delivered-To: mailing list commits@nifi.apache.org
Received: (qmail 22233 invoked by uid 99); 14 Nov 2016 21:52:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Nov 2016 21:52:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 9521F2C4C7B
	for <commits@nifi.apache.org>; Mon, 14 Nov 2016 21:52:58 +0000 (UTC)
Date: Mon, 14 Nov 2016 21:52:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.13009581.1475592972000.273804.1479160378607@Atlassian.JIRA>
In-Reply-To: <JIRA.13009581.1475592972000@Atlassian.JIRA>
References: <JIRA.13009581.1475592972000@Atlassian.JIRA> <JIRA.13009581.1475592972501@arcas>
Subject: [jira] [Commented] (MINIFI-115) Upgrade NiFi dependencies to 1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 14 Nov 2016 21:53:00 -0000


    [ https://issues.apache.org/jira/browse/MINIFI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665153#comment-15665153 ] 

ASF GitHub Bot commented on MINIFI-115:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/43#discussion_r87866531
  
    --- Diff: minifi-assembly/src/main/assembly/dependencies.xml ---
    @@ -36,23 +36,38 @@
                 	<exclude>minifi-bootstrap</exclude>
                     <exclude>minifi-resources</exclude>
                     <!-- Filter items introduced via transitive dependencies that are provided in associated NARs -->
    +                <exclude>org.apache.nifi:nifi-framework-core:1.0.0</exclude>
    +                <exclude>zookeeper</exclude>
                     <exclude>spring-aop</exclude>
                     <exclude>spring-context</exclude>
    -                <exclude>spring-security-core</exclude>
                     <exclude>spring-beans</exclude>
    +                <exclude>spring-expression</exclude>
                     <exclude>swagger-annotations</exclude>
                     <exclude>slf4j-log4j12</exclude>
                     <exclude>aspectjweaver</exclude>
                     <exclude>h2</exclude>
                     <exclude>netty</exclude>
                     <exclude>jaxb-impl</exclude>
    -                <exclude>httpclient</exclude>
                     <exclude>mail</exclude>
                     <exclude>log4j</exclude>
    +                <exclude>lucene-analyzers-common</exclude>
                     <exclude>lucene-queryparser</exclude>
                     <exclude>commons-net</exclude>
    +                <exclude>spring-context</exclude>
    +                <exclude>spring-security-core</exclude>
                 </excludes>
             </dependencySet>
    +        <dependencySet>
    +            <scope>runtime</scope>
    +            <useProjectArtifact>false</useProjectArtifact>
    +            <outputDirectory>lib</outputDirectory>
    --- End diff --
    
    This is to provide explicit inclusion of the following artifacts.  I found out the tough way that the include/exclude directives will do a simple pattern matching.  So nifi-framework-core also excludes minifi-framework-core given the match.  Will put a comment on this to clarify.  Had one at some point, but got lost to the sands of time and many iterations.


> Upgrade NiFi dependencies to 1.0
> --------------------------------
>
>                 Key: MINIFI-115
>                 URL: https://issues.apache.org/jira/browse/MINIFI-115
>             Project: Apache NiFi MiNiFi
>          Issue Type: Task
>          Components: Core Framework
>    Affects Versions: 0.0.1
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>             Fix For: 0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)