nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MINIFI-107) Support for Process Groups
Date Fri, 04 Nov 2016 21:14:58 GMT

    [ https://issues.apache.org/jira/browse/MINIFI-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637703#comment-15637703
] 

ASF GitHub Bot commented on MINIFI-107:
---------------------------------------

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/50#discussion_r86620366
  
    --- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/RemoteProcessingGroupSchema.java
---
    @@ -50,17 +48,18 @@
     
         public RemoteProcessingGroupSchema(Map map) {
             name = getRequiredKeyAsType(map, NAME_KEY, String.class, REMOTE_PROCESSING_GROUPS_KEY);
    -        url = getRequiredKeyAsType(map, URL_KEY, String.class, REMOTE_PROCESSING_GROUPS_KEY);
    -        inputPorts = convertListToType(getRequiredKeyAsType(map, INPUT_PORTS_KEY, List.class,
REMOTE_PROCESSING_GROUPS_KEY), "input port", RemoteInputPortSchema.class, INPUT_PORTS_KEY);
    +        String wrapperName = "RemoteProcessingGroup(name: {name})".replace("{name}",
StringUtil.isNullOrEmpty(name) ? "unknown" : name);
    --- End diff --
    
    This may be a basic question but why use ".replace" (which compiles a pattern) instead
of just doing string concatenation?


> Support for Process Groups
> --------------------------
>
>                 Key: MINIFI-107
>                 URL: https://issues.apache.org/jira/browse/MINIFI-107
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>            Reporter: Bryan Rosander
>            Assignee: Bryan Rosander
>
> Process groups are a good way to simplify the design part of development in NiFi.  MiNiFi
Java currently doesn't support them but should in order to make designing templates compatible
with MiNiFi a better experience.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message