nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ald...@apache.org
Subject nifi-minifi git commit: Add the PR template to the repository.
Date Thu, 20 Oct 2016 18:37:11 GMT
Repository: nifi-minifi
Updated Branches:
  refs/heads/master c1f33d5bb -> 09b35f3ab


Add the PR template to the repository.


Project: http://git-wip-us.apache.org/repos/asf/nifi-minifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi-minifi/commit/09b35f3a
Tree: http://git-wip-us.apache.org/repos/asf/nifi-minifi/tree/09b35f3a
Diff: http://git-wip-us.apache.org/repos/asf/nifi-minifi/diff/09b35f3a

Branch: refs/heads/master
Commit: 09b35f3ab12b8ceccc2ca37484eeb2c758995eab
Parents: c1f33d5
Author: Aldrin Piri <aldrin@apache.org>
Authored: Tue Oct 18 16:19:54 2016 -0400
Committer: Aldrin Piri <aldrin@apache.org>
Committed: Thu Oct 20 09:18:57 2016 -0400

----------------------------------------------------------------------
 .github/PULL_REQUEST_TEMPLATE.md | 27 +++++++++++++++++++++++++++
 pom.xml                          |  1 +
 2 files changed, 28 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/nifi-minifi/blob/09b35f3a/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 0000000..e76fd43
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,27 @@
+Thank you for submitting a contribution to Apache NiFi - MiNiFi.
+
+In order to streamline the review of the contribution we ask you
+to ensure the following steps have been taken:
+
+### For all changes:
+- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
+     in the commit message?
+
+- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
+
+- [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)?
+
+- [ ] Is your initial contribution a single, squashed commit?
+
+### For code changes:
+- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean
install at the root nifi-minifi folder?
+- [ ] Have you written or updated unit tests to verify your changes?
+- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that
is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

+- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under
minifi-assembly?
+- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found
under minifi-assembly?
+
+### For documentation related changes:
+- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
+
+### Note:
+Please ensure that once the PR is submitted, you check travis-ci for build issues and submit
an update to your PR as soon as possible.

http://git-wip-us.apache.org/repos/asf/nifi-minifi/blob/09b35f3a/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index aebe315..f5cdae0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -777,6 +777,7 @@ limitations under the License.
                         <exclude>nbactions.xml</exclude> <!-- courtesy excludes
for netbeans users -->
                         <exclude>DEPENDENCIES</exclude> <!-- auto generated
file by apache's maven config while building sources.zip -->
                         <exclude>.travis.yml</exclude> <!-- Travis CI Build
Descriptor File -->
+                        <exclude>.github/PULL_REQUEST_TEMPLATE.md</exclude> <!--
PR Template for GitHub that does not have a mechanism of including comments -->
                     </excludes>
                 </configuration>
                 <dependencies>


Mime
View raw message